Issue 118024 - UNDO in Impress does not work properly
Summary: UNDO in Impress does not work properly
Status: CONFIRMED
Alias: None
Product: Impress
Classification: Application
Component: editing (show other issues)
Version: 3.4.0 Beta (OOo)
Hardware: PC Linux, all
: P2 Normal with 2 votes (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-14 20:59 UTC by gleppert
Modified: 2019-11-26 05:21 UTC (History)
10 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
PowerPoint pptx format example for bug 118024 (70.54 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2011-09-24 16:05 UTC, Truong Vu
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description gleppert 2011-05-14 20:59:30 UTC
UNDO/REDO in Impress does not work properly.The UNDO behaviour is first inconsistent and second, generally does not work at all (particularly in the main content frame).

In other words: The most basic task a user wants to perform in a presentation programme is typing, undoing and redoing, this issue is a terrible drawback of Impress. It makes Impress almost unusable. This issue made every single colleague of mine swearing badly when they had to use Impress. Although they really like using Writer, they kindly asked me to send them Powerpoint files instead of Impress files. The only reason is this issue.

How to reproduce:
* Open an empty presentation
* Enter some text into the content frame of the slide. While typing, the
buttons "undo" and "redo" are greyed out. These buttons are most times simply not working.
* If you click with the mouse somewhere outside the main content frame, then
the "undo"/"redo" buttons resume to work again. If you once click on "undo",
only EVERYTHING having edited last time within the content frame is being undone.

However, the UNDO-behaviour is inconsistent:
* Sometimes, there is no UNDO-functionality available at all.
* Sometimes, however, the UNDO-functionality works perfectly like it should be: The UNDO-button is visible and it is possible to actually delete the last editing word by word.
* Sometimes, however, the UNDO-functionality works only partly: While editing
the UNDO-button is greyed out and becomes only visible when you move the mouse
over it and wait for a few seconds. Only then, UNDO works like it should.

The severity of the problem is different depending where you edit:
* In title frame, UNDO works only sometimes
* In main content frame, UNDO generally does not work. However, in rare occasions, let's say, only every 30th time clicking into the main content frame and typing something there. UNDO is actually working correctly. But only very very rarely.
* In additional text frames UNDO works only sometimes.
* If you add a standard form and type text into is, UNDO always works
correctly.

System: Ubuntu 10.10, Gnome 2, OOo-DEV 3.4Beta from OpenOffice.org website. English OOo UI, German Gnome UI

I also opened a bug report in the sister project LibreOffice. Please see here: https://bugs.freedesktop.org/show_bug.cgi?id=36138
Comment 1 bmjlk 2011-05-21 21:58:36 UTC
I have followed your steps given encounter the same set of problems with "Undo/Redo" feature with one exception

Undo does not work even if it is a standard text book.

How to reproduce:
 Create an empty slide.
 Insert a text box
 Type few lines while pressing enter key after each line.
 Then, make one line Bold.
 Press undo button.

We expect to undo the last action (Bold). But deletes the text entered (sometimes all, sometimes few lines, sometimes it merges lines together)

I would like to add couple of more point to "The severity of the problem is different depending where you edit:"

   Even in a stranded text box, Undo does not work properly.

   Unto/Redo seems to be working properly with objects in the impress such as  
   rectangles,  circles...etc.
Comment 2 Truong Vu 2011-09-24 16:05:54 UTC
Created attachment 76804 [details]
PowerPoint pptx format example for bug 118024
Comment 3 Truong Vu 2011-09-24 16:07:25 UTC
I did attach a file by mistake, the file is for other bug.
Comment 4 Matt Smith 2011-09-28 03:39:19 UTC
I was able to reproduce this problem by following the given steps above on  
OOo-dev 3.4.0 DEV300m106 (Build:9582) on Windows 7 64-bit. In addition, the keyboard shortcuts for UNDO/REDO behave the same way as the buttons. This problem also occurs when typing in a cell of an inserted table.

    How to reproduce:

	 Insert a table into a slide.
	 Type in any cell of the table.
	 Click the UNDO button (or use CTRL Z if using a Windows or Linux Machine)
Comment 5 Rodrigo Rodriguez 2011-10-01 00:53:55 UTC
I was Able to replicate the problem of the Undo function. My system specifications are the following:

------------------
System Information
------------------
Time of this report: 9/30/2011, 17:03:01
   Operating System: Windows 7 Professional 64-bit (6.1, Build 7601) Service Pack 1 (7601.win7sp1_gdr.110622-1506)
           Language: English (Regional Setting: English)
System Manufacturer: Gigabyte Technology Co., Ltd.
       System Model: Z68A-D3-B3
               BIOS: Award Modular BIOS v6.00PG
          Processor: Intel(R) Core(TM) i5-2500K CPU @ 3.30GHz (4 CPUs), ~3.6GHz
             Memory: 8192MB RAM
Available OS Memory: 8176MB RAM
          Page File: 4234MB used, 12113MB available
        Windows Dir: C:\Windows
    DirectX Version: DirectX 11
     DxDiag Version: 6.01.7601.17514 32bit Unicode

----------------------
OpgenOffice Infomation
----------------------
OOo-dev 3.4.0
DEV300m106 (Build:9582)

------------------------------
Steps to reproduce the problem
------------------------------

Input:
1.Start -> All Programs -> OOo-dev 3.4 -> OOo-dev Impress
2.Create an empty slide with default settings.
3.Click on the "Click to add text" frame.
4. Type "asdf" then return/enter. Do this four times (Type “asdf” without the quotes).
5. Press Ctrl+Z four times

Actual Output:
You will see “asdfasdfasdfasdf”

Expected Ouput:
asdf
asdf

---------------------
Further Analysis
---------------------
Open Office 3.4 is not reverting the words typed but only the return lines. If you try this with Power Point 2010, then each time you press Ctrl-Z, you go back one step. Meaning, the first Ctrl-Z will revert a Return, next a word “asdf”, then a Return again, and so on. However, it doesn’t take 8 undo’s to return to the original state. It actually takes 6 Ctrl-Z’s to revert back to their original “Click to add subtitle” state (6 times and not 8 because PowerPoint tries to guess your intentions and reverts back completely at the 6th undo). This might be a good additional feature to think about. 

Also, if you do the Input again up to Step 4. Then deselect any frame and press Ctrl-Z, the entire text you typed will be deleted. This should have the same an Expected Output. Meaning that Open Office should detect that we need to undo text that was typed in a frame, go to that frame and start undoing by word typed and by return lines. If you try this with Power Point as well, you will see the correct output.
Comment 6 Oliver-Rainer Wittmann 2012-06-13 12:17:46 UTC
getting rid of value "enhancement" for field "severity".
For enhancement the field "issue type" shall be used.
Comment 7 Perze Ababa 2012-06-16 14:15:17 UTC
I was able to reproduce the issue using the steps as mentioned by the creator of the issue. I used the following configuration and versions for the replication and my follow-up tests.

Platform used to replicate: Mac OS 10.6.8
Powerpoint Version: 14.2.1 build 120420 for Mac 2011
Apache Open Office Version: 3.4.0 AOO340m1(Build:9590) - Rev. 1325589

Steps used to Reproduce:

1. Launch Open Office
2. Create a New presentation
3. Select Empty Presentation
4. Click on the create button
5. Wait for the empty presentation slide to show up
6. Click on the “Click to add text” box
7. type  “asdf”, press [Enter] key
8. type  “asdf”, press [Enter] key
9. type  “asdf”, press [Enter] key
10. type  “asdf”, press [Enter] key
11. use the undo command 4 times using (ctrl-z for pc or cmd-z for mac), alternatively you can also execute this by selecting the edit menu and choosing the undo option (4 times)
12. after ‘undo’-ing 4 times the expected result should display a blank canvas but it doesn’t. Instead, it shows “asdfasdfasdfasdf”

Here’s a link of a screencast that reproduces the problem: http://screencast.com/t/jvmhjYxYkevk

Other Notes:

As you can see, instead of reverting back to a blank slate, the typed text remains and doesn’t get reverted to its original blank state. As follow up tests, I wanted to see how other Open Office products behave under the same condition. So, I chose the Spreadsheet and the Text Document App. Basically following the same steps as above, instead of using the [Enter] key as delimiter between strings, i used the [space] key mainly for convenience reasons with the spreadsheet app. You will notice that each app behaves differently and the spreadsheets app displays the erroneous behavior while the Text Document app behaves closest to our ideal behavior. See linked screencasts for each application.

Open Office Spreadsheet: http://screencast.com/t/E1oAAkVkDA
Open Office Text Document: http://screencast.com/t/qWriJfCwArXy

As a Final Follow Up test I also wanted to check how a competing product behaves under the same condition. I’ve chosen Microsoft Power Point since that is what I conveniently have. Same steps, but you’ll see that Powerpoint cleanly reverts back to its original blank state. Please see see the linked screencast.

Microsoft Powerpoint:  http://screencast.com/t/L49s9bOqFPi6

From the above tests, I can clearly deduce that the issue is with the function that handles and tracks the data that can be used for the undo function. In a real world scenario the undo button might not even be that important but it’s there for a reason and it should work. I believe we have enough proof to show that it doesn’t work in this version of Impress and even in Spreadsheets. We have proof that this functionality works in Microsoft Powerpoint and I am in good knowledge to say that this also works in Google Documents Presentation software as well.
Comment 8 hanya 2012-06-16 14:39:46 UTC
This issue would be fixed by issue 119400.
Comment 9 Li Feng Wang 2012-09-07 03:33:26 UTC
can reproduce on AOO trunk r1378003

reproduce steps:
* Open an empty presentation
* Enter some text into the content frame of the slide. While typing, the
buttons "undo" and "redo" are greyed out. These buttons are most times simply not working.
* If you click with the mouse somewhere outside the main content frame, then
the "undo"/"redo" buttons resume to work again. If you once click on "undo",
only EVERYTHING having edited last time within the content frame is being undone.
Comment 10 Scarlen Quinsamolle 2019-11-26 05:21:31 UTC
The UNDO functionality does not revert last action only. When you click on UNDO option, it reverts all the actions that you added in your presentation. It does not allow you to undo one by one.
Apache OpenOffice 4.1.7
STEPS TO REPRODUCE THE ISSUE:
1.	Create a new presentation in OpenOffice Impress
2.	Notice that undo and redo options are disabled
3.	Add a title in your presentation.
4.	UNDO option is disabled unless you click out the title frame.
5.	Add text to your presentation.
6.	Click on UNDO option.
7.	Notice that all the text added has been reverted.
8.	Sometimes you may notice that undo functionality takes few seconds to show the result.
9.	About REDO option, it is available only when the UNDO option was used.
I also tested this behavior with Images and different text formats (font, text color, font size), in all these cases the UNDO functionality reverts all actions added to the presentation. Sometimes you may need to click out of the frame that you are currently working on to enable the UNDO option.
This issue causes to revert all the actions done in the presentation, so the user is not able to use UNDO option at all.