Apache OpenOffice (AOO) Bugzilla – Issue 116572
calc listbox entries are lost on open *.ods file
Last modified: 2017-05-20 10:30:44 UTC
steps to reproduce: - open "listbox_demo.ods" from http://www.openoffice.org/issues/show_bug.cgi?id=76572 - listbox control has no entries btw.: - open same file with OO 3.2.1: empty cells are ignored as requested by issue 76572 - open same file with OO 3.3rc10: empty cells are part of the listbox entries again pretty strange!
confirming, grabbing, targeting opening the document in a non-product version of DEV300 m98 yields 3 assertions: Error: FormCellBindingHelper::doConvertAddressRepresentations: caught an exception! ooo/xmloff/source/forms/formcellbinding.cxx at Line 481 Error: OFormLayerXMLImport_Impl::documentDone: caught an exception while binding to a cell! From File ooo/xmloff/source/forms/layerimport.cxx at Line 604 Error: FormCellBindingHelper::doConvertAddressRepresentations: caught an exception! From File ooo/xmloff/source/forms/formcellbinding.cxx at Line 481
note: reading the cell binding broke between m96 and m97.
.
fixed in CWS dba34d find more information about this CWS, like when it is available in the master builds, in EIS, the Environment Information System: http://eis.services.openoffice.org/EIS2/cws.ShowCWS?Path=DEV300/dba34d
fs->dr: would you be so kind to review the patch? changeset which introduced the regression: http://hg.services.openoffice.org/DEV300/rev/94cd079ac931#l12.51 patch: http://hg.services.openoffice.org/cws/dba34d/rev/9d9dc36e9d90
note: the fix here is about the list box being completely empty. The "empty cells should be ignored" part is not fixed (as written over there in issue 76572, I am not even sure I would consider this legitimate - I do not know at all why it worked this way in 3.2.1).
Reviewed and accepted. I did not notice the regression, because using either OOO or XL_A1 works for 2D references, but not for 3D references :-(
The fix consists of two changes: http://hg.services.openoffice.org/cws/dba34d/rev/308a498da39d http://hg.services.openoffice.org/cws/dba34d/rev/ac14f12e5bfc got a review/approval for the first of the two from PL offline. fs->oj: could you please review the second changeset?
Code reviewed.
@fs: could you please check if your bugfix will fix this problem too: "reference values from checkboxes are lost on open *.ods file (OO 3.4)" if not, i will submit an issue ...
Created attachment 75969 [details] test for checkbox reference values
hmm? Why did you re-open the issue? It is fixed in CWS dba34d, which is not even in QA at the moment, so how to you know the issue is not fixed?
yes, the problem in your attached document is fixed in CWS dba34d, too.
fs->msc: please verify in CWS dba34d
verified in cws dba34d