Issue 116572 - calc listbox entries are lost on open *.ods file
Summary: calc listbox entries are lost on open *.ods file
Status: CLOSED FIXED
Alias: None
Product: Base
Classification: Application
Component: code (show other issues)
Version: DEV300m98
Hardware: Unknown All
: P3 Trivial (vote)
Target Milestone: 3.4.0
Assignee: marc.neumann
QA Contact: issues@dba
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2011-01-23 13:28 UTC by Oliver Brinzing
Modified: 2017-05-20 10:30 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
test for checkbox reference values (8.62 KB, application/octet-stream)
2011-03-02 08:11 UTC, Oliver Brinzing
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description Oliver Brinzing 2011-01-23 13:28:23 UTC
steps to reproduce:

- open "listbox_demo.ods" from
  http://www.openoffice.org/issues/show_bug.cgi?id=76572

- listbox control has no entries
 
btw.: 
- open same file with OO 3.2.1: empty cells are ignored as requested
  by issue 76572
- open same file with OO 3.3rc10: empty cells are part of the listbox
  entries again
pretty strange!
Comment 1 Frank Schönheit 2011-01-28 13:22:29 UTC
confirming, grabbing, targeting

opening the document in a non-product version of DEV300 m98 yields 3 assertions:

Error: FormCellBindingHelper::doConvertAddressRepresentations: caught an
exception! ooo/xmloff/source/forms/formcellbinding.cxx at Line 481

Error: OFormLayerXMLImport_Impl::documentDone: caught an exception while binding
to a cell! From File ooo/xmloff/source/forms/layerimport.cxx at Line 604

Error: FormCellBindingHelper::doConvertAddressRepresentations: caught an
exception! From File ooo/xmloff/source/forms/formcellbinding.cxx at Line 481
Comment 2 Frank Schönheit 2011-02-03 13:59:57 UTC
note: reading the cell binding broke between m96 and m97.
Comment 3 ocke.janssen 2011-02-10 08:56:40 UTC
.
Comment 4 Frank Schönheit 2011-02-16 13:19:38 UTC
fixed in CWS dba34d

find more information about this CWS, like when it is available in the master
builds, in EIS, the Environment Information System:
http://eis.services.openoffice.org/EIS2/cws.ShowCWS?Path=DEV300/dba34d
Comment 5 Frank Schönheit 2011-02-16 13:25:17 UTC
fs->dr: would you be so kind to review the patch?
changeset which introduced the regression:
http://hg.services.openoffice.org/DEV300/rev/94cd079ac931#l12.51
patch:
http://hg.services.openoffice.org/cws/dba34d/rev/9d9dc36e9d90
Comment 6 Frank Schönheit 2011-02-16 13:27:46 UTC
note: the fix here is about the list box being completely empty. The "empty
cells should be ignored" part is not fixed (as written over there in issue
76572, I am not even sure I would consider this legitimate - I do not know at
all why it worked this way in 3.2.1).
Comment 7 daniel.rentz 2011-02-16 13:36:50 UTC
Reviewed and accepted. I did not notice the regression, because using either OOO
or XL_A1 works for 2D references, but not for 3D references :-(
Comment 8 Frank Schönheit 2011-02-16 14:15:03 UTC
The fix consists of two changes:
http://hg.services.openoffice.org/cws/dba34d/rev/308a498da39d
http://hg.services.openoffice.org/cws/dba34d/rev/ac14f12e5bfc
got a review/approval for the first of the two from PL offline.

fs->oj: could you please review the second changeset?
Comment 9 ocke.janssen 2011-02-16 14:28:41 UTC
Code reviewed.
Comment 10 Oliver Brinzing 2011-03-02 08:08:29 UTC
@fs: could you please check if your bugfix will fix this problem too:
"reference values from checkboxes are lost on open *.ods file (OO 3.4)"
if not, i will submit an issue ...
Comment 11 Oliver Brinzing 2011-03-02 08:11:56 UTC
Created attachment 75969 [details]
test for checkbox reference values
Comment 12 Oliver Brinzing 2011-03-02 08:17:56 UTC
.
Comment 13 Frank Schönheit 2011-03-02 21:02:52 UTC
hmm? Why did you re-open the issue? It is fixed in CWS dba34d, which is not even in QA at the moment, so how to you know the issue is not fixed?
Comment 14 Frank Schönheit 2011-03-02 21:12:04 UTC
yes, the problem in your attached document is fixed in CWS dba34d, too.
Comment 15 Frank Schönheit 2011-03-16 09:14:09 UTC
fs->msc: please verify in CWS dba34d
Comment 16 marc.neumann 2011-03-23 10:25:41 UTC
verified in cws dba34d