Issue 115789 - No manifest:version attribute in manifest:manifest element
Summary: No manifest:version attribute in manifest:manifest element
Status: CLOSED FIXED
Alias: None
Product: xml
Classification: Code
Component: code (show other issues)
Version: OOO330m1
Hardware: Mac All
: P3 Trivial (vote)
Target Milestone: 3.4.1
Assignee: michael.ruess
QA Contact: issues@xml
URL:
Keywords: odf_validation
Depends on:
Blocks:
 
Reported: 2010-11-25 17:34 UTC by chriskimball
Modified: 2011-01-24 14:20 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Fails validation in META-INF/manifest.xml (8.07 KB, application/vnd.oasis.opendocument.text)
2010-11-25 17:35 UTC, chriskimball
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description chriskimball 2010-11-25 17:34:57 UTC
Files from OpenOffice.org Writer fail the validation at the OpenOffice
validation site allegedly because the manifest:manifest (root) tag in the
META-INF/manifest.xml file lacks a version attribute.  

upload:///Test from Win 7.odt/META-INF/manifest.xml[2,88]:Error:element
"manifest:manifest" is missing "version" attribute
upload:///Test from Win 7.odt/META-INF/manifest.xml[5,85]:Error:element
"manifest:file-entry" is missing "media-type" attribute
upload:///Test from Win 7.odt:Info:validation errors found
upload:///Test from Win 7.odt:Info:Generator: OpenOffice.org/3.3$Win32
OpenOffice.org_project/330m15$Build-9546


There's no requirement that I can find that manifest:manifest takes ANY
attribute other than the namespace declaration.
Comment 1 chriskimball 2010-11-25 17:35:56 UTC
Created attachment 75141 [details]
Fails validation in META-INF/manifest.xml
Comment 2 Marcus 2010-11-26 09:00:02 UTC
reassigned
Comment 3 michael.brauer 2010-11-29 11:09:22 UTC
Set target to 3.4, and re-assigned issue.
Comment 4 svante.schubert 2010-11-29 11:39:22 UTC
I can confirm the issue, in the attached document with the latest version of the 
online validator
http://tools.odftoolkit.org/odfvalidator/

The version attribute is missing in the root element of the manifest.xml.
Instead the missing mimetype attribute is a problem of the validator.

It can also reproduced by the latest online available OOo version
OOo-dev/3.4$Win32 OpenOffice.org_project/300m94$Build-9547
and
OpenOffice.org/3.3$Win32 OpenOffice.org_project/330m15$Build-9546
By saving any document, for instance an empty text document.
Comment 5 chriskimball 2010-12-01 12:34:01 UTC
Respectfully, in the normal course of affairs when might this problem be resolved?

(I'm an advocate for the OpenDocument Text format, choosing to distribute ODT
files of biblical text at my site <tanach.us>.  In promoting this new feature
and ODT I've claimed that my files validate with your validator.  And they did a
few weeks ago.  Now they don't, a source of consternation and embarrassment.)
Comment 6 mikhail.voytenko 2010-12-06 15:27:58 UTC
fixed in cws fwk162
Comment 7 chriskimball 2010-12-06 16:52:26 UTC
Today, 6 dec 2010, http://tools.services.openoffice.org/odfvalidator/ fails to
validate the trival OpenWriter file test.odt attached.  Same error results.

Are the repairs to "cws fwk162" for  the validator or OpenOffice Writer?  When
will they take effect for the site users?

Thanks,

Chris Kimball
Comment 8 chriskimball 2010-12-06 16:53:03 UTC
Today, 6 dec 2010, http://tools.services.openoffice.org/odfvalidator/ fails to
validate the trival OpenWriter file test.odt attached.  Same error results.

Are the repairs to "cws fwk162" for  the validator or OpenOffice Writer?  When
will they take effect for the site users?

Thanks,

Chris Kimball
Comment 9 mikhail.voytenko 2010-12-07 09:10:08 UTC
The changes in cws fwk162 fix the bug in package generation in OOo. As the
target field shows it is going to be integrated in OOo3.4 branch.

If you would like to test the cws after the integration in the development
branch you should wait for integration of the cws. Before the cws is integrated
this bug have to be set to Verified ( that would mean that the cws is already in
QA ). After the bug is verified you can track the status of the cws using the
following link:
https://tools.services.openoffice.org/EIS2/cws.ShowCWS?logon=true&Id=9948&Path=DEV300%2Ffwk162
Comment 10 chriskimball 2010-12-07 12:41:16 UTC
The response by sus Mon Nov 29 11:39:22 +0000 2010 indicates the problem is in
the validator: 

"The version attribute is missing in the root element of the manifest.xml.
Instead the missing mimetype attribute is a problem of the validator."

In creating my own manifest files, nothing is accepted by your validator.  Would
you please provide an example of a valid manifest file?  Or at least its root
element.


Comment 11 mikhail.voytenko 2010-12-07 13:18:06 UTC
The latest ODF1.2 draft explicitly requires that manifest:manifest element
contains manifest:version attribute. Before this bug was fixed, it had not been
the case.

I have no information regarding the validator problem with the media-type that
sus has mentioned.

Changing the Summary to avoid further confusions. This bug is only about
manifest:version attribute in manifest:manifest element. I am not sure how the
validator issues are handled, but if issuezilla bugs are used for them as well,
then we need a new issue for validator.
Comment 12 chriskimball 2010-12-08 16:57:20 UTC
The ODF validator has, apparently, been repaired.  My unchanged files now
validate.  OOWriter 3.3 files don't.

Thanks,

Chris
Comment 13 mikhail.voytenko 2011-01-06 07:21:09 UTC
mav->mru: Please verify in fwk162.
Comment 14 michael.ruess 2011-01-06 16:36:50 UTC
Verified in CWS fwk162.
Comment 15 michael.ruess 2011-01-24 14:20:55 UTC
Checked in DEV300m98.