Issue 112422 - Animations broken 3.2 -> 3.2.1
Summary: Animations broken 3.2 -> 3.2.1
Status: CLOSED FIXED
Alias: None
Product: Impress
Classification: Application
Component: viewing (show other issues)
Version: OOo 3.2.1
Hardware: All Windows, all
: P2 Trivial (vote)
Target Milestone: OOo 3.3
Assignee: wolframgarten
QA Contact: issues@graphics
URL:
Keywords: regression
: 112872 (view as issue list)
Depends on:
Blocks: 111112
  Show dependency tree
 
Reported: 2010-06-15 15:39 UTC by eric.savary
Modified: 2017-05-20 10:22 UTC (History)
6 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
broken animation (422.55 KB, application/vnd.oasis.opendocument.presentation)
2010-06-15 15:41 UTC, eric.savary 		no flags Details
The fix (1015 bytes, patch)
2010-07-02 01:26 UTC, thb 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description eric.savary 2010-06-15 15:39:50 UTC 
Open attached presentation in 3.2 and 3.2.1.
3.2.1 shows repaint problems, object appear inside of other, disappear at the end 
of an animation path...
Comment 1 eric.savary 2010-06-15 15:41:43 UTC 
Created attachment 70015 [details]
broken animation
Comment 2 eric.savary 2010-06-15 15:44:31 UTC 
Sorry for the crap description in words.
Hopping you will clearly see the difference between both version.
Tested on Windows only but XP and Vista, different graphic devices and XP was on 
VMware -> same problem
Comment 3 groucho266 2010-06-23 10:45:20 UTC 
I can reproduce this with a simpler setup:
1. Create three Rectangle shapes A, B, and C.
2. Turn B and C into a group G and place them to overlap with A.
3. Assign Fade Out animation to A, and Fade In animation to G.
4. Make the animation on G start with that on A.

Start presentation and animation.  At the end of the animation on G there is a
short flicker and the paint error.

Two factors are crucial to reproduce this:
1. There is a group involved.
2. The duration of the fade out effect on A is not shorter than the duration of
the fade in effect on G.
2a. If the durations are the same then the intersecting area of A and G is missing.
2b. If the duration of the effect on A is longer then the area G-A is missing.
Comment 4 groucho266 2010-06-23 15:46:50 UTC 
This looks like a clipping problem.  It may have been caused by fixes for issue
105939.
Comment 5 groucho266 2010-06-23 16:53:29 UTC 
Yup, that's it.  I locally turned back the fix for issue 105939 and the
animation is painted as expected.

@thb: Can you provide a fix in the next week?  Alternatively I can revert the
changes so that you have more time for the fix.
Comment 6 thb 2010-06-24 09:51:20 UTC 
@af: I think so, will have a look. thanks for the thorough analysis!

@es: sure this broken in 3.2.1?! Issue 105939 went into the 3.3 code line!
Comment 7 thb 2010-07-02 01:26:03 UTC 
Created attachment 70353 [details]
The fix
Comment 8 thb 2010-07-02 01:30:51 UTC 
@af: see attached patch for the fix. please commit that to a suitable CWS of
yours, on vacation & neither bandwidth nor diskspace for hg stunts here, sadly.

FWIW, this was a stupid oversight, in that the intended behaviour should have
been equal to a polygonal 'OR' operation (see e.g. basegfx's
solvePolygonOperationOr(), and the previous implementation), but missed the
subsequent normalization steps. Which is ~indistinguishable from the correct
behaviour for simple clips.
Comment 9 thb 2010-07-02 01:31:55 UTC 
Reassigning to af for further handling. TIA!
Comment 10 thb 2010-07-02 01:34:54 UTC 
@jacqueline: fixes your repaint bug, too.
Comment 11 groucho266 2010-07-02 10:12:53 UTC 
@thb: Thanks for the fix.

Applied the patch and verified that it fixes the problem.
Comment 12 groucho266 2010-07-02 13:19:20 UTC 
*** Issue 112872 has been marked as a duplicate of this issue. ***
Comment 13 groucho266 2010-07-06 16:37:29 UTC 
@wg: Please verify.
Comment 14 wolframgarten 2010-07-07 13:08:17 UTC 
Verified in CWS.