Issue 110859 - sw: fix ww8 cpp check warnings
Summary: sw: fix ww8 cpp check warnings
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: code (show other issues)
Version: DEV300m76
Hardware: All Linux, all
: P3 Trivial (vote)
Target Milestone: ---
Assignee: dtardon
QA Contact: issues@sw
URL:
Keywords:
Depends on:
Blocks: 106602
  Show dependency tree
 
Reported: 2010-04-14 08:46 UTC by caolanm
Modified: 2013-08-07 14:44 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
fixes, also remove some old meaningless header guards (3.32 KB, patch)
2010-04-14 08:47 UTC, caolanm 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description caolanm 2010-04-14 08:46:07 UTC 
i.e. low hanging non-virtual dtors and one error return path which would leak mem
Comment 1 caolanm 2010-04-14 08:47:10 UTC 
Created attachment 68913 [details]
fixes, also remove some old meaningless header guards
Comment 2 caolanm 2010-04-14 08:49:06 UTC 
done in cmcfixes
Comment 3 caolanm 2010-04-26 08:35:39 UTC 
reassign for sanity checking
Comment 4 dtardon 2010-04-26 14:45:04 UTC 
Okay, but I do not think that ~MSWordSection needs to be virtual. The sole
created object of the sole subclass (WW8_WrPlcSepx) of MSWordSection is managed
by class WW8Export, so it will always be destructed correctly.
Comment 5 caolanm 2010-06-08 20:47:29 UTC 
integrated m81