Apache OpenOffice (AOO) Bugzilla – Issue 108863
[From Symphony] Application.Run could not work correctly
Last modified: 2013-07-11 12:49:11 UTC
1. Root Cause: Application.Run(...) does not return the result of executing a macro. 2. Resolution: Return the result of executing a macro.
Created attachment 67546 [details] Fix for issue.
looks ok, but a) first hunk to msvbahelper.cxx seems no longer to be needed b) msvbahelper has now changed and CallXScript is used instead of XScript so the patch needs to be regenerated, othewise this looks good :-), please take it over ( and needs commiting to an upstream cws )
Created attachment 68364 [details] Unit test case for this issue.
Created attachment 68365 [details] Unit test case for this issue.
The msvbahelper.cxx should still be changed: aRes.SetResolvedMacro( sProcedure.Insert( '.', 0 ).Insert( sModule, 0).Insert( '.', 0 ).Insert( sContainer, 0 ) ), this line should be moved to the 'else' statement in method 'resolveVBAMacro(...)'. Because the this line will be called two time if the macro name includes the document name, such as: Application.Run("'Application API Macro.xls'!My_Func_Sum", 3, 5). I regenerated the patch, please review.
Created attachment 68366 [details] Change the patch because CallXScript is used instead of XScript.
->lihuiibm looks good to me!! thanks
Created attachment 68984 [details] Fix the issue in test document" Application_API_auto_TST-641E2B.xls"
Created attachment 77249 [details] Fix the issue in test document" Application_API_auto_TST-641E2B.xls" Update path for AOO 3.4 (is still not correct)
Created attachment 77250 [details] Change the patch because CallXScript is used instead of XScript. Update the path and remove copyright changes. Still untested. Only for reference: the textdocissue patch looks newer.
Created attachment 79079 [details] Patch for bug 108863
Comment on attachment 79079 [details] Patch for bug 108863 Repatch it for AOO 3.5, passed the UT for the two sample.
"pfg" committed SVN revision 1376557 into trunk: #i108863# Application.Run could not work correctly.In Application.Run Return ...
Committed indeed, thanks!!
Update Target Milestone to AOO 3.5.0.
Latest build is Aoo_Trunk_20121207.1915 Rev.1413470, marked is as verified.
close it