Issue 106768 - sc: dereference followed by check of pointer
Summary: sc: dereference followed by check of pointer
Status: CLOSED FIXED
Alias: None
Product: Calc
Classification: Application
Component: code (show other issues)
Version: DEV300m64
Hardware: All All
: P3 Trivial (vote)
Target Milestone: 3.4.0
Assignee: niklas.nebel
QA Contact: issues@sc
URL:
Keywords:
Depends on:
Blocks: 106602
  Show dependency tree
 
Reported: 2009-11-10 14:23 UTC by caolanm
Modified: 2017-05-20 10:22 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
if we need to check, then we need to check earlier (432 bytes, patch)
2009-11-10 14:24 UTC, caolanm 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description caolanm 2009-11-10 14:23:47 UTC 
Doesn't make a lot of sense to dereference a pointer and then check if the
pointer was 0. Assuming it can be 0 then here's a patch.
Comment 1 caolanm 2009-11-10 14:24:32 UTC 
Created attachment 66042 [details]
if we need to check, then we need to check earlier
Comment 2 niklas.nebel 2010-10-04 16:26:15 UTC 
Fixed in CWS "dr77".
Comment 3 niklas.nebel 2010-11-10 10:53:55 UTC 
Nothing to see for QA, so I set it to "verified" myself.