Issue 106673 - i18npool: no need to dynamically allocate a buffer
Summary: i18npool: no need to dynamically allocate a buffer
Status: CLOSED FIXED
Alias: None
Product: Internationalization
Classification: Code
Component: i18npool (show other issues)
Version: DEV300m64
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: dtardon
QA Contact: issues@l10n
URL:
Keywords:
Depends on:
Blocks: 106602
  Show dependency tree
 
Reported: 2009-11-06 10:54 UTC by caolanm
Modified: 2013-08-07 15:02 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
simple patch (952 bytes, patch)
2009-11-06 10:55 UTC, caolanm 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description caolanm 2009-11-06 10:54:39 UTC 
genconv_dict.cxx dynamically allocates some memory it doesn't free. The arg is a
static value, so no need to dynamically allocate at all
Comment 1 caolanm 2009-11-06 10:55:34 UTC 
Created attachment 65987 [details]
simple patch
Comment 2 caolanm 2009-11-06 10:57:33 UTC 
done in cmcfixes66
Comment 3 caolanm 2009-11-09 09:59:58 UTC 
Well well, there *is* a reason to dynamically allocate it. They don't fit in the
default stack size allowed under windows. Lets fix it differently then.
Comment 4 caolanm 2009-11-10 15:36:38 UTC 
reassign for sanity testing
Comment 5 dtardon 2009-11-11 14:28:12 UTC 
looks fine -> verified
Comment 6 caolanm 2009-11-17 16:19:40 UTC 
closed, integrated m65