Apache OpenOffice (AOO) Bugzilla – Issue 106477
xmerge: XMergeFilter.cpp: memory leak
Last modified: 2009-11-17 16:19:18 UTC
For source code file xmerge/source/activesync/XMergeFilter.cpp, there is a memory leak for local variable szJavaHome around line 380. The source code is lRet = ::RegOpenKeyEx(hKey, _T(szCurrentJava), 0, KEY_READ, &hDataKey); if (lRet != ERROR_SUCCESS) { RegCloseKey(hKey); return NULL; } Suggest new code lRet = ::RegOpenKeyEx(hKey, _T(szCurrentJava), 0, KEY_READ, &hDataKey); if (lRet != ERROR_SUCCESS) { RegCloseKey(hKey); delete [] szJavaHome; return NULL; }
Created attachment 65792 [details] heres a fix
I wonder if this code is built even under windows ?, maybe we can simply remove the entire dir ?. Anyway, attached is a plausible fix
I'll take this one of no one objects. cmc->mba: Focus on that build modularization :-)
done in cmcfixes66
reassign for sanity testing
looks good
closed, integrated m65