Issue 106431 - ulfconv.cxx: resource leak
Summary: ulfconv.cxx: resource leak
Status: CLOSED FIXED
Alias: None
Product: Installation
Classification: Application
Component: code (show other issues)
Version: DEV300m63
Hardware: All Linux, all
: P3 Trivial (vote)
Target Milestone: OOo 3.3
Assignee: dtardon
QA Contact: issues@installation
URL:
Keywords:
Depends on:
Blocks: 106602
  Show dependency tree
 
Reported: 2009-10-29 12:50 UTC by dcb314
Modified: 2009-11-17 16:18 UTC (History)
1 user (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
straightforward fix (803 bytes, patch)
2009-10-29 13:01 UTC, caolanm 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description dcb314 2009-10-29 12:50:44 UTC 
For source code file setup_native/source/ulfconv/ulfconv.cxx,
around line 164 is the source code line

   FILE * fp = fopen(file, "r");

I fail to find a matching call to fclose. This looks
like a resource leak to me. Suggest add call to fclose.
Comment 1 caolanm 2009-10-29 13:01:18 UTC 
Created attachment 65755 [details]
straightforward fix
Comment 2 caolanm 2009-10-29 13:01:39 UTC 
confirmed, added patch to fix
Comment 3 Olaf Felka 2009-10-29 14:04:14 UTC 
reassigned
Comment 4 ingo.schmidt-rosbiegal 2009-10-29 14:33:39 UTC 
is -> dv: please have a look at this patch
Comment 5 caolanm 2009-11-06 11:05:34 UTC 
I'll take this if noone minds and fix this group together
Comment 6 caolanm 2009-11-06 11:06:58 UTC 
done in cmcfixes66
Comment 7 caolanm 2009-11-10 15:35:54 UTC 
reassign for sanity testing
Comment 8 dtardon 2009-11-12 07:24:03 UTC 
looks good
Comment 9 caolanm 2009-11-17 16:18:54 UTC 
closed, integrated m65