Issue 105098 - [Mac] inserting files (e. g. images) into a document by drag & drop isn't possible
Summary: [Mac] inserting files (e. g. images) into a document by drag & drop isn't pos...
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: ui (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: Mac Mac OS X, all
: P3 Trivial with 4 votes (vote)
Target Milestone: 4.1.2
Assignee: hdu@apache.org
QA Contact:
URL:
Keywords:
: 124434 125010 (view as issue list)
Depends on:
Blocks:
 
Reported: 2009-09-15 16:45 UTC by flet
Modified: 2016-08-30 21:25 UTC (History)
9 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: 4.1.0
Developer Difficulty: ---
pescetti: 4.1.2_release_blocker+


Attachments
Patch for drag n drop bug (2.62 KB, patch)
2015-06-21 01:43 UTC, Manik
no flags Details | Diff
Patch for drag n drop bug with rev #2 (2.61 KB, patch)
2015-06-21 01:49 UTC, Manik
mm30f: review? (hdu)
Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description flet 2009-09-15 16:45:44 UTC
Well, this defect may be a missing feature... However it used to work on OOo
WinXP and NeoOffice (MacOS X).

When draging an image file from the Mac OS Desktop or Finder to a window with an
open (and editable) OOo presentation, the cursor changes into a green "+" as
expected, but then when dropping the image nothing happens. 

The expected behavior would be insertion of the image in the presentation. It
does not work. The image insertion using the menu entry works fine though.
Comment 1 wolframgarten 2009-10-08 10:25:36 UTC
Works here on version 3.1.1 without problems. Could you have another look with
the official release, please? Thanks. Which kind of image files do you drag?
Comment 2 flet 2009-10-15 08:10:37 UTC
Well, the package I downloaded is 3.1.1 (OOo_3.1.1_MacOSXPPC_install_fr.dmg from
http://download.openoffice.org/contribute.html?download=bouncer&product%3DOpenOffice.org%26os%3Dmacosxppc%26lang%3Dfr%26version%3D3.1.1)
but the version in the About panel says 3.1.0 (OOO310m11), build 9399. I don't
know which version number is correct... It's a version in French BTW.

Anyway - the bug happends with JPEG files (confirmed many times with all kinds
of JPEG).

HTH
Comment 3 wolframgarten 2009-10-15 08:45:18 UTC
The about box seems to be more precise in this case. Possibly they have linked
the wrong version. It is labled as 3.1.1 but actually is a 3.1.
But even with this version the problem is not reproducible here. I am using Mac
OSX version 10.5.8, and you?
Comment 4 flet 2009-10-16 08:43:58 UTC
It's Mac OS X 10.4.11, running on a iBook G4 PPC.
I know it sounds like legacy stuff but hey, it's still alive & kicking :)!
Comment 5 wolframgarten 2009-10-19 08:47:52 UTC
That may be part of the problem. I must see if I have a system available to test
this...
Comment 6 b.osi.ooo 2010-01-26 08:54:43 UTC
So far verified on MacOS X 10.4.11 INTEL
jpeg file from testautomation project:
testautomation/global/input/graf_inp/borabora.jpg
StarOffice 3.2 rc4 provided by Sun Microsystems : OK
OpenOfice.org DEV300m68 provided by Maho:
ftp://ooopackages.good-day.net/pub/OpenOffice.org/MacOSX/ (who is also the only
one who builds PPC builds AFAIK): OK

Currently downloading: OOo 3.1 from him...to see if it is reproduceable there...

Will try later on my 10.4 PPC at home...
Comment 7 b.osi.ooo 2010-01-26 19:01:05 UTC
No Problem on MacOS X INTEL.

Problem is only on MacOS X PPC platform.
I used the build from ooopackages.good-day.net

In writer the 'Insert section' dialog comes up, which does not give an image as
a result - in other applications just nothing happens.
Looks like it did never work for OOo builds.

Who will fix it?
Comment 8 clippka 2010-01-26 21:14:47 UTC
cl->pl: have we (sun) ppc mac hardware?
Comment 9 philipp.lohmann 2010-01-27 10:08:17 UTC
Assigning to MacPort.
Comment 10 thorsten.ziehm 2010-09-23 15:10:07 UTC
OOo 3.3 is in showstopper-mode. This issue is too old to be a stopper for the
current release. I change the target to OOo 3.x. Please change the target
accordingly when a fix is near to be integrated into a code line. 
Comment 11 mroe 2014-03-17 09:11:15 UTC
*** Issue 124434 has been marked as a duplicate of this issue. ***
Comment 12 mroe 2014-05-30 20:31:14 UTC
*** Issue 125010 has been marked as a duplicate of this issue. ***
Comment 13 cdmooo 2014-05-30 20:44:26 UTC
I do not believe Issue 125010 is the same issue as this. I am on a modern Mac PowerMac laptop running the latest OS Mavericks with the latest edition of OpenOffice.

This is not an older or legacy issue with a PPC unit.

You simply cannot drag and drop an image into OpenOffice without the image opening up in Draw.
Comment 14 hdu@apache.org 2014-06-02 08:25:10 UTC
Since the problem is reproducible Mac Intel with OOo330, AOO341, AOO401 and AOO410 the MacPPC-aspect can be ignored. The bug is still current with the latest AOO release and on the latest platform release.
Comment 15 mroe 2014-09-03 10:20:58 UTC
*** Issue 125562 has been marked as a duplicate of this issue. ***
Comment 16 hadouma 2014-09-03 12:10:09 UTC
This whole thing is becoming quite ridiculous. Talking about it, asking people to give yet more information, moving it to a bug as duplicate of another bug that is not likely to be solved anywhere soon, this all takes up more time and resources than just fixing it. Besides it generates a lot of frustration among users, including myself. So can you please fix it ?
Comment 17 Manik 2015-05-22 12:16:00 UTC
I made a commit on Libre for this http://cgit.freedesktop.org/libreoffice/core/commit/?id=cfdd89f10fdc15b36bd0d1023e49ca3752feb51e
If anybody with working osx build can check and commit it'd great.
I'd try to check this weekend if possible.
Comment 18 Marcus 2015-05-25 08:50:07 UTC
@manik: As this is the bugtracker for OpenOffice and not LibrOffice, we cannot check this.

But it would be great if you could attach the patch here under Apache license (AL v2). Thanks in advance.
Comment 19 Manik 2015-06-20 02:26:55 UTC
@Marcus
Alright, I'll attach it ASAP.
Comment 20 Manik 2015-06-21 01:43:17 UTC
Created attachment 84802 [details]
Patch for drag n drop bug
Comment 21 Manik 2015-06-21 01:49:14 UTC
Created attachment 84803 [details]
Patch for drag n drop bug with rev #2
Comment 22 Manik 2015-06-23 15:19:05 UTC
I've added the patch, whom should I add for review?
Comment 23 hdu@apache.org 2015-06-23 15:28:11 UTC
Comment on attachment 84803 [details]
Patch for drag n drop bug with rev #2

reviewing the patch...
Comment 24 SVN Robot 2015-06-24 07:08:32 UTC
"hdu" committed SVN revision 1687177 into trunk:
#i105098# fix drag&drop insertion of files/images on Mac
Comment 25 SVN Robot 2015-06-24 07:12:35 UTC
"hdu" committed SVN revision 1687177 into trunk:
#i105098# fix drag&drop insertion of files/images on Mac
Comment 26 hdu@apache.org 2015-06-24 07:20:32 UTC
Many thanks for solving the problem and for providing the fix under the matching license! It is applied now (revision 1687177). Manik, I didn't have your full name so I just provided your email in the Fixed-by line of the commit. I can update the revision comment with your name if you provide it.
Comment 27 Manik 2015-06-26 10:00:23 UTC
My full name is "Manik Malhotra"
Comment 28 hdu@apache.org 2015-06-29 07:02:25 UTC
The revision comment has been updated to give you full credit. Thanks again for the patch!
Comment 29 Andrea Pescetti 2015-07-11 07:46:08 UTC
Approving Herbert's request, notified to dev list, for making this a Release Blocker for 4.1.2.
Comment 30 hadouma 2015-07-11 08:18:13 UTC
Well, well...... acknowledging and fixing this minor issue has taken 6 years since first reporting
Comment 31 SVN Robot 2015-07-15 00:31:07 UTC
"pescetti" committed SVN revision 1691118 into branches/AOO410:
#i105098# fix drag&drop insertion of files/images on Mac
Comment 32 Andrea Pescetti 2015-10-17 22:24:09 UTC
There are several people in CC. It would be great if one could take the time to download OpenOffice 4.1.2-RC2 (English, for Mac OS X: https://dist.apache.org/repos/dist/dev/openoffice/4.1.2-rc2-r1707648/binaries/en-US/Apache_OpenOffice_4.1.2_MacOS_x86-64_install_en-US.dmg ) and comment on whether the bug is now fixed for the upcoming OpenOffice version 4.1.2. Thanks!
Comment 33 hadouma 2015-10-18 09:05:57 UTC
(In reply to Andrea Pescetti from comment #32)
> There are several people in CC. It would be great if one could take the time
> to download OpenOffice 4.1.2-RC2 (English, for Mac OS X:
> https://dist.apache.org/repos/dist/dev/openoffice/4.1.2-rc2-r1707648/
> binaries/en-US/Apache_OpenOffice_4.1.2_MacOS_x86-64_install_en-US.dmg ) and
> comment on whether the bug is now fixed for the upcoming OpenOffice version
> 4.1.2. Thanks!

Tried it today and it now works.
Thank you so much
Comment 34 Andrea Pescetti 2015-10-18 09:28:51 UTC
Thank you for checking! Marking VERIFIED.
Comment 35 cdmooo 2015-10-19 14:39:11 UTC
I also confirm it's fixed on OS X El Capitan with an iMac Retina 5K. This has been a long time coming, but thanks so much for your work in resolving it.
Comment 36 Kay 2016-08-30 21:25:19 UTC
Closing.