Issue 104786 - Check that the ODF version is the same in manifest.xml and content.xml
Summary: Check that the ODF version is the same in manifest.xml and content.xml
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: DEV300m56
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 3.2
Assignee: h.ilter
QA Contact: issues@framework
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-04 11:51 UTC by mikhail.voytenko
Modified: 2017-05-20 10:29 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
The document with removed ODF version in manifest.xml (11.99 KB, application/vnd.oasis.opendocument.text)
2009-09-08 08:39 UTC, mikhail.voytenko 		no flags Details
Another document with removed manifest:version attribute (7.29 KB, application/vnd.oasis.opendocument.spreadsheet)
2009-09-08 08:40 UTC, mikhail.voytenko 		no flags Details
Draw document with removed version attribute. (7.49 KB, application/vnd.sun.xml.draw)
2009-09-08 08:40 UTC, mikhail.voytenko 		no flags Details
Impress document with removed manifest:version attribute (9.49 KB, application/vnd.sun.xml.impress)
2009-09-08 08:41 UTC, mikhail.voytenko 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description mikhail.voytenko 2009-09-04 11:51:07 UTC 
There are some new policies regarding ODF1.2 document. But the implementation
uses entry from manifest.xml to get the version from the document. To make the
check more safe ( especially in case of encrypted documents ) the framework
should check that the value in content.xml is the same as in the manifest.xml as
a part of document consistency check.
Comment 1 mikhail.voytenko 2009-09-08 08:34:41 UTC 
Fixed
Comment 2 mikhail.voytenko 2009-09-08 08:37:09 UTC 
mav->hi: Please verify the issue. To do so, please remove or edit the
manifest:version attribute in the manifest.xml.
Comment 3 mikhail.voytenko 2009-09-08 08:39:24 UTC 
Created attachment 64597 [details]
The document with removed ODF version in manifest.xml
Comment 4 mikhail.voytenko 2009-09-08 08:40:07 UTC 
Created attachment 64598 [details]
Another document with removed manifest:version attribute
Comment 5 mikhail.voytenko 2009-09-08 08:40:44 UTC 
Created attachment 64599 [details]
Draw document with removed version attribute.
Comment 6 mikhail.voytenko 2009-09-08 08:41:33 UTC 
Created attachment 64600 [details]
Impress document with removed manifest:version attribute
Comment 7 h.ilter 2009-09-10 12:25:20 UTC 
verified in encsig09 = OK
Comment 8 malte_timmermann 2009-09-14 09:45:20 UTC 
Changing the version in content.xml is still possible.

But the intention for this issue was to protect manifest.xml in encrypted or
signed documents, where manipulations to content.xml are not possible anyway.

For normal documents, where this integrity check might also be interesting, I
wrote the follow up issue #105048#