Issue 100346 - Crash:copying filter's data from excel 2003.
Summary: Crash:copying filter's data from excel 2003.
Status: CLOSED FIXED
Alias: None
Product: Calc
Classification: Application
Component: code (show other issues)
Version: DEV300m42
Hardware: PC All
: P2 Trivial (vote)
Target Milestone: ---
Assignee: oc
QA Contact: issues@sc
URL:
Keywords:
Depends on:
Blocks: 95768
  Show dependency tree
 
Reported: 2009-03-19 08:56 UTC by yonggang.mao
Modified: 2013-08-07 15:14 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
patch to add NULL check on shell instance (1.31 KB, patch)
2009-03-19 14:30 UTC, kyoshida 		no flags Details | Diff
actually let's use this one instead. (1.31 KB, patch)
2009-03-19 14:35 UTC, kyoshida 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description yonggang.mao 2009-03-19 08:56:47 UTC 
Description:
1.Create a new *.ods document in OOom42.
2.Create a new *.xls 2003.
3.I input some characters in B2 to B8 in excel 2003,for
example,a1,a2,a3,a4,a5,a6 etc.
4.click data-filter-autofilter,select autofilter flag,select a3,selected B2 to 
B4,copy a1 and a3 to *.ods document.
5.the ods document will crash.
Comment 1 daniel.rentz 2009-03-19 10:32:10 UTC 
taking over
Comment 2 daniel.rentz 2009-03-19 11:28:31 UTC 
target
Comment 3 daniel.rentz 2009-03-19 11:35:33 UTC 
dep.
Comment 4 daniel.rentz 2009-03-19 11:40:47 UTC 
dr->kohei: reason of this crash is the unchecked usage of docshell in
sc/source/filter/excel/xilink.cxx, XclImpSupbook::LoadCachedValues(). The
docshell is NULL e.g. when pasting from clipboard. Please check if there are
other places related to external links where a docshell pointer is used unchecked.
Comment 5 kyoshida 2009-03-19 14:30:04 UTC 
I've found two more locations where the shell pointer is not checked for NULL
value.  I'll post a patch to fix it in a minute.
Comment 6 kyoshida 2009-03-19 14:30:52 UTC 
Created attachment 61046 [details]
patch to add NULL check on shell instance
Comment 7 kyoshida 2009-03-19 14:35:26 UTC 
Created attachment 61047 [details]
actually let's use this one instead.
Comment 8 kyoshida 2009-03-19 14:37:46 UTC 
Both of these locations are related to external links.  BTW I wasn't aware that
the shell can be NULL for clipboard handling.  Good to know.
Comment 9 daniel.rentz 2009-03-19 14:47:53 UTC 
Thanks, Kohei. Committed.
Comment 10 daniel.rentz 2009-03-24 13:09:21 UTC 
back to QA
Comment 11 oc 2009-03-24 13:52:44 UTC 
verified in internal build cws_calc31stopper4
Comment 12 amy2008 2009-04-01 06:50:57 UTC 
Verified in OOo310m8 on WinXP and Fedora9.
Closing
Li Meiying
Comment 13 amy2008 2009-06-09 09:49:37 UTC 
cc
Comment 14 amy2008 2009-06-09 10:13:44 UTC 
Change build as DEV300m42