Issue 100300 - Unreferenced external sheets saved lead to "Update links?" dialog and can't be removed.
Summary: Unreferenced external sheets saved lead to "Update links?" dialog and can't b...
Status: CLOSED FIXED
Alias: None
Product: Calc
Classification: Application
Component: save-export (show other issues)
Version: OOO310m5
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: oc
QA Contact: issues@sc
URL:
Keywords:
Depends on:
Blocks: 95768
  Show dependency tree
 
Reported: 2009-03-18 10:47 UTC by ooo
Modified: 2013-08-07 15:14 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description ooo 2009-03-18 10:47:57 UTC 
Having referenced an external document's sheet data and removed the reference
in the current document, the sheet data is still saved and when opening the
document the "Update links to external files?" dialog is presented. There's no
entry under menu Edit->Links, the user has no chance to get rid of this
situation. Only in older versions a hidden sheet containing the external data
can be shown and manually deleted.

Scenario to reproduce:
1. Create new document.
2. In a formula, reference any cell in another document, e.g.
   ='extern.ods'#Sheet1.A1
3. Delete that formula cell.
4. Save the document.
5. Reload the document.
6. Dialog is shown.
Comment 1 ooo 2009-03-18 10:53:09 UTC 
Working on this, nominated as 3.1 blocker.
Comment 2 ooo 2009-03-19 19:49:29 UTC 
In cws calc31stopper4:

revision 269767
sc/inc/cell.hxx
sc/inc/column.hxx
sc/inc/conditio.hxx
sc/inc/document.hxx
sc/inc/externalrefmgr.hxx
sc/inc/table.hxx
sc/inc/validat.hxx
sc/source/core/data/cell.cxx
sc/source/core/data/column.cxx
sc/source/core/data/conditio.cxx
sc/source/core/data/documen3.cxx
sc/source/core/data/documen4.cxx
sc/source/core/data/table2.cxx
sc/source/core/data/validat.cxx
sc/source/filter/xml/XMLStylesExportHelper.cxx
sc/source/filter/xml/xmlexprt.cxx
sc/source/ui/docshell/docsh.cxx
sc/source/ui/docshell/externalrefmgr.cxx
sc/source/ui/inc/docsh.hxx
sc/source/ui/unoobj/fmtuno.cxx

Only tables of the external data cache are saved that are referenced by:
- charts
- formula cells
- conditional formats using "Formula is"
- data validity criteria using a formula as "Value"
Comment 3 ooo 2009-03-20 15:19:57 UTC 
Reassigning to QA for verification.
Comment 4 oc 2009-03-25 15:52:47 UTC 
verified in internal build cws_calc31stopper4
Comment 5 larysahitekschool 2009-04-29 21:48:29 UTC 
Verified on OOo-dev 3.2.0 DEV300m44 WinXP
Comment 6 natalia_hitekschool 2009-05-01 22:55:54 UTC 
Verified on OOo310m9 and OOo-Dev300m44, Windows Vista.
1. Created doc "XXX"
2. Enterd number in B6 and saved
3. Created anew doc
4. Insert "=" + reference to 'XXX' #Sheet1.B6 in A1 of a new document
5. Delete A1
6. Save New doc as "YYYY" and close
7. Reload "YYYY" 

Expected result: File is opened, no references in A1

Results:
      On OOo-Dev300m44: message "This file contains links to other files." A1 
doesn't contain any refence
      On OOo310m9: file is opened, no message, no reference
Comment 7 redflagzhulihua 2009-06-10 08:06:00 UTC 
Verified in OOo3.1
Closing...