Apache OpenOffice (AOO) Bugzilla – Issue 100235
Improvementprogram is missing in tools options (all languages but EN_US)
Last modified: 2009-03-30 20:33:02 UTC
- install e.g OOO310_m5_fr ot *_it - go to tools options *Office - the improvement program entry is missing . is ok in the en-US build
The option is missing in the German OOo310_m5 too.
Adjusting summary. The improvement options page is visible in EN_US UI only. This issue was decided to be a 3.1 release blocker. Dependency to issue 95768 set by UL.
accepting issue
In resource RID_OFADLG_OPTIONS_TREE_PAGES the StringArray SID_GENERAL_OPTIONS is missing the last entry < "" ; RID_SVXPAGE_IMPROVEMENT ; > when using a localized userinterface. http://svn.services.openoffice.org/opengrok/xref/OOO310_m5/svx/source/dialog/treeopt.src#166 Thus, the tree does not get populated completely (also the array has a different length for localized/nonlocalized versions). @ihi: Can you comment on this?
Looking at the sourcecode and the localisations there is an additional problem. The source code includes a hack that removes the %Productname from the string "%Productname Improvement Program". A look at the localisations reveals this to leads to lots of broken strings in localized versions, for example german has "%Productname-Verbesserungsprogramm" leading to the tabpage title "-Verbesserungsprogramm". While removing the hyphen might still be fixable other languages use constructs that arent. For OOo 3.1 I propose to simply use "Improvement Program" as NON-localized fixed string.
Hi, what kind of string is this???? < "" ; RID_SVXPAGE_IMPROVEMENT ; > Why this is a empty string? Please add at least a dummy string!
if you change the string to for example < "x" ; RID_SVXPAGE_IMPROVEMENT ; > then the fallback mechanism add that string also to the localized resource strings. But be aware that you add a new translateable string .... but could be an workarround for this issue ItemList [ ar ] = { < "%PRODUCTNAME" ; 0; > ; < "ïºï»³ïºŽï»§ïºŽïº— ïºŽï» ï»¤ïº´ïº˜ïº§ïºªï»£" ; RID_SFXPAGE_GENERAL; > ; < "ﻉﺎﻣ" ; OFA_TP_MISC; > ; < "ﺎﻟﺫﺎﻛïºïº“" ; OFA_TP_MEMORY; > ; < "ﻉﺮﺿ" ; OFA_TP_VIEW ; > ; < "ﻂﺑﺎﻋﺓ" ; RID_SFXPAGE_PRINTOPTIONS; > ; < "ïºŽï» ï»¤ïº³ïºïºïºŽïº—" ; RID_SFXPAGE_PATH; > ; < "ïºï»¸ï»Ÿï»ïºŽï»§" ; RID_SVXPAGE_COLOR; > ; < "ïºŽï» ïº¨ï»ƒï»®ï»ƒ" ; RID_SVX_FONT_SUBSTITUTION ; > ; < "ïºï»¸ï»£ïºŽï»§" ; RID_SVXPAGE_INET_SECURITY ; > ; < "ïºŽï» ï»¤ï»ˆï»«ïº" ; RID_SVXPAGE_COLORCONFIG ; > ; < "ïºŽï» ï»£ï»®ïº¼ï» ï»³ïº“" ; RID_SVXPAGE_ACCESSIBILITYCONFIG ; > ; < "ïºïºŽï»“ïº" ; RID_SVXPAGE_OPTIONS_JAVA ; > ; < "ﻩﻮﻳﺓ ïºŽï» ïº¸ïº’ï»›ïº“" ; RID_SVXPAGE_SSO ; > ; < "ﺖﺣﺪﻴﺛ ï»Šïº‘ïº ïºï»ºï»¨ïº—ﺮﻨﺗ" ; RID_SVXPAGE_ONLINEUPDATE ; > ; < "x" ; RID_SVXPAGE_IMPROVEMENT ; > ; }; but the better way is to define a real en-US string.
CCed: md
Ok, this is ugly. There are two ways to "solve" this: Using < "Improvement Program" ; RID_SVXPAGE_IMPROVEMENT ; >. This would trigger new localization alerts, that we would need to ignore. Removing the entry from the StringArray and hardcoding the string and the addition of the TabPage in the source code. In both cases the string would not be localized. The first solution would require quite a bit of communication to the localization community, but would otherwise be a bit cleaner. The second solution would create yet another ugly hack that would have to be removed ASAP after the release. Opinions?
Ok, I found a workable solution for 3.1. The string is localized as the title of the tabpage. I will recycle that string for the tree too. For 3.2 I will do a clean solution fixing that broken empty localized string. Fix for 3.1 will be in sw31bf08, fix for 3.2 will likely be in fwk103 (I better use a new bug for that, I guess)
fixed in cws sw31bf08 revision 269618.
@of: Please verify
of: Looks good in the provided cws languages fr, de, pt_BR and en_US.
Verified in OOO310_m8 .deb FR version - Closing - Sophie