Issue 100235 - Improvementprogram is missing in tools options (all languages but EN_US)
Summary: Improvementprogram is missing in tools options (all languages but EN_US)
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: OOO310m5
Hardware: All All
: P2 Trivial (vote)
Target Milestone: OOo 3.1
Assignee: Olaf Felka
QA Contact: issues@framework
URL:
Keywords:
Depends on:
Blocks: 95768
  Show dependency tree
 
Reported: 2009-03-16 15:13 UTC by Olaf Felka
Modified: 2009-03-30 20:33 UTC (History)
6 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description Olaf Felka 2009-03-16 15:13:40 UTC
- install e.g OOO310_m5_fr ot *_it
- go to tools options *Office
- the improvement program entry is missing
. is ok in the en-US build
Comment 1 Regina Henschel 2009-03-16 15:38:32 UTC
The option is missing in the German OOo310_m5 too.
Comment 2 stefan.baltzer 2009-03-16 17:52:50 UTC
Adjusting summary. The improvement options page is visible in EN_US UI only.
This issue was decided to be a 3.1 release blocker. Dependency to issue 95768
set by UL. 

Comment 3 bjoern.michaelsen 2009-03-17 11:03:06 UTC
accepting issue
Comment 4 bjoern.michaelsen 2009-03-17 12:42:07 UTC
In resource RID_OFADLG_OPTIONS_TREE_PAGES the StringArray SID_GENERAL_OPTIONS is
missing the last entry < "" ; RID_SVXPAGE_IMPROVEMENT ; > when using a localized
userinterface.
http://svn.services.openoffice.org/opengrok/xref/OOO310_m5/svx/source/dialog/treeopt.src#166

Thus, the tree does not get populated completely (also the array has a different
length for localized/nonlocalized versions).

@ihi: Can you comment on this?
Comment 5 bjoern.michaelsen 2009-03-17 13:01:25 UTC
Looking at the sourcecode and the localisations there is an additional problem.
The source code includes a hack that removes the %Productname from the string
"%Productname Improvement Program". A look at the localisations reveals this to
leads to lots of broken strings in localized versions, for example german has
"%Productname-Verbesserungsprogramm" leading to the tabpage title
"-Verbesserungsprogramm". While removing the hyphen might still be fixable other
languages use constructs that arent.

For OOo 3.1 I propose to simply use "Improvement Program" as NON-localized fixed
string.
Comment 6 ivo.hinkelmann 2009-03-17 13:13:05 UTC
Hi,

what kind of string is this????

< "" ; RID_SVXPAGE_IMPROVEMENT ; >

Why this is a empty string? Please add at least a dummy string!
Comment 7 ivo.hinkelmann 2009-03-17 13:23:37 UTC
if you change the string to for example

< "x" ; RID_SVXPAGE_IMPROVEMENT ; >

then the fallback mechanism add that string also to the localized resource
strings. But be aware that you add a new translateable string .... but could be
an workarround for this issue

   ItemList [ ar ] =
    {
        < "%PRODUCTNAME" ; 0; > ;
        < "ïºï»³ïºŽï»§ïºŽïº— ﺎﻠﻤﺴﺘﺧﺪﻣ" ;  RID_SFXPAGE_GENERAL; > ;
        < "ﻉﺎﻣ" ;  OFA_TP_MISC; > ;
        < "ﺎﻟﺫﺎﻛﺭﺓ" ; OFA_TP_MEMORY; > ;
        < "ﻉﺮﺿ" ; OFA_TP_VIEW ; > ;
        < "ﻂﺑﺎﻋﺓ" ; RID_SFXPAGE_PRINTOPTIONS; > ;
        < "ﺎﻠﻤﺳïºïº­ïºŽïº—" ;  RID_SFXPAGE_PATH; > ;
        < "ïºï»¸ï»Ÿï»­ïºŽï»§" ;  RID_SVXPAGE_COLOR; > ;
        < "ﺎﻠﺨﻃﻮﻃ" ; RID_SVX_FONT_SUBSTITUTION ; > ;
        < "ïºï»¸ï»£ïºŽï»§" ; RID_SVXPAGE_INET_SECURITY ; > ;
        < "ﺎﻠﻤﻈﻫﺭ" ;        RID_SVXPAGE_COLORCONFIG        ; > ;
        < "ﺎﻠﻣﻮﺼﻠﻳﺓ" ; RID_SVXPAGE_ACCESSIBILITYCONFIG ; > ;
        < "ïºïºŽï»“ïº" ; RID_SVXPAGE_OPTIONS_JAVA ; > ;
        < "ﻩﻮﻳﺓ ﺎﻠﺸﺒﻛﺓ" ; RID_SVXPAGE_SSO ; > ;
        < "ﺖﺣﺪﻴﺛ ﻊﺑﺭ ïºï»ºï»¨ïº—ﺮﻨﺗ" ; RID_SVXPAGE_ONLINEUPDATE ; > ;
        < "x" ; RID_SVXPAGE_IMPROVEMENT ; > ;
    };

but the better way is to define a real en-US string.
Comment 8 mdxonefour 2009-03-17 13:27:15 UTC
CCed: md
Comment 9 bjoern.michaelsen 2009-03-17 14:43:44 UTC
Ok, this is ugly.
There are two ways to "solve" this:
Using < "Improvement Program" ; RID_SVXPAGE_IMPROVEMENT ; >. This would trigger
new localization alerts, that we would need to ignore.
Removing the entry from the StringArray and hardcoding the string and the
addition of the TabPage in the source code.

In both cases the string would not be localized. The first solution would
require quite a bit of communication to the localization community, but would
otherwise be a bit cleaner. The second solution would create yet another ugly
hack that would have to be removed ASAP after the release.

Opinions?

Comment 10 bjoern.michaelsen 2009-03-17 16:45:47 UTC
Ok, I found a workable solution for 3.1. The string is localized as the title of
the tabpage. I will recycle that string for the tree too.
For 3.2 I will do a clean solution fixing that broken empty localized string.
Fix for 3.1 will be in sw31bf08, fix for 3.2 will likely be in fwk103 (I better
use a new bug for that, I guess)
Comment 11 bjoern.michaelsen 2009-03-17 16:54:02 UTC
fixed in cws sw31bf08 revision 269618.
Comment 12 bjoern.michaelsen 2009-03-17 18:34:36 UTC
@of: Please verify
Comment 13 Olaf Felka 2009-03-20 13:59:52 UTC
of: Looks good in the provided cws languages fr, de, pt_BR and en_US.
Comment 14 sgautier.ooo 2009-03-30 20:33:02 UTC
Verified in OOO310_m8 .deb FR version - Closing - Sophie