Issue 100014 - Not responding when import .doc file
Summary: Not responding when import .doc file
Status: CLOSED FIXED
Alias: None
Product: Writer
Classification: Application
Component: open-import (show other issues)
Version: OOO310m4
Hardware: PC Windows XP
: P2 Trivial (vote)
Target Milestone: ---
Assignee: michael.ruess
QA Contact: issues@sw
URL:
Keywords: oooqa, regression
Depends on:
Blocks: 95768
  Show dependency tree
 
Reported: 2009-03-08 03:43 UTC by 95217686d
Modified: 2013-08-07 14:43 UTC (History)
6 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
.doc file cases the not responding (459.00 KB, application/msword)
2009-03-08 03:44 UTC, 95217686d
no flags Details
simplified example 1 - table_in_table_2.odt (55.16 KB, application/vnd.oasis.opendocument.text)
2009-03-09 13:33 UTC, majukr05
no flags Details
simplified example 2 - table_in_table_2.doc (59.50 KB, application/msword)
2009-03-09 13:34 UTC, majukr05
no flags Details

Note You need to log in before you can comment on or make changes to this issue.
Description 95217686d 2009-03-08 03:43:35 UTC
When import Word Document .doc (not all cases) but the file attached in this
issue will cause "Not Reponding" to swriter.exe
Comment 1 95217686d 2009-03-08 03:44:25 UTC
Created attachment 60810 [details]
.doc file cases the not responding
Comment 2 Rainer Bielefeld 2009-03-08 07:56:06 UTC
I checked with "Ooo Dev 3.1.0 multilingual version English UI WIN XP: [OOo310m2
(Build 9385)]" and can NOT confirm the reported effect.
I will try m4 soon.

@95217686d:
Can you contribute a crash report ID?
Comment 3 jbf.faure 2009-03-08 22:39:56 UTC
I confirm the problem for OOO310m4 (+ lang pack FR) under Ubuntu 8.04 : CPU
100%, I need to kill soffice process.
OOo 3.0.1 FR opens this bugdoc without problem.
Set keyword regression

@ 95217686d : please provide information how this file has been produced. It is
the result of a conversion odt -> doc ?

Regards
JBF
Comment 4 95217686d 2009-03-09 03:19:35 UTC
This file convert from Ooo 3.0.1 from odt to doc.

Then I open this file from MS Office and modified the doc file.

Then open in Ooo310m4. But now, most of our other .doc format file are unable to
open with Ooo310m4 and all are converted by Ooo3.0.1 
Comment 5 majukr05 2009-03-09 11:56:44 UTC
I could replicate the problem for OOO310m4 / WinXP.
Same results as described by jbfaure.
Comment 6 majukr05 2009-03-09 13:30:43 UTC
Similar (simplified):

- .odt created in OOO310m4 / WinXP [table_in_table_2.odt]
- saved as .doc (97/2000/XP) [table_in_table_2.doc]
- .doc can be re-imported in OOo 3.0.1
- .doc cannot be re-imported in OOO310m4.

Comment 7 majukr05 2009-03-09 13:33:10 UTC
Created attachment 60826 [details]
simplified example 1 - table_in_table_2.odt
Comment 8 majukr05 2009-03-09 13:34:50 UTC
Created attachment 60827 [details]
simplified example 2 - table_in_table_2.doc
Comment 9 majukr05 2009-03-09 16:02:43 UTC
@ 95217686d: 
After I had removed the *note* on page 26, I could open <test3.doc>
also in OOO310m4.
Comment 10 eric.savary 2009-03-09 16:20:02 UTC
@MOD: don't know if it may be your area but could you please have a look at the
first attached document and compare with majukr05's last statement ( #desc10 ):
"After I had removed the *note* on page 26, I could open <test3.doc> also in
OOO310m4."
Comment 11 max.odendahl 2009-03-10 00:23:34 UTC
works for me with m42 and m2, will need to download m4...

Can someone confirm? It works with m2, but does not work with m4?

mod->es: coment 10 sounds like a notes issue, but notes8 got integrated into m1,
so this does not really fit
Comment 12 max.odendahl 2009-03-10 01:11:19 UTC
Trying to delete a note inside these documents and saving afterwards crashes the
application, so I guess the loop when loading is also related to this.

It crashes in WW8TableInfo::processTableBox. Looks like Issue 98465 is related,
which I think wanted to fix exactly this crash and was integrated into m4(or
maybe not?). Btw, the other issue talks about a crash on Linux, but crashed here
on Mac.

-> reassign to  hbrinkm, mru on cc who qa'ed issue 98465
Comment 13 Oliver-Rainer Wittmann 2009-03-10 11:54:19 UTC
Taking over this issue.

Fix in progress in cws sw31bf07.
Comment 14 michael.ruess 2009-03-10 11:57:20 UTC
Changing target to 3.1 as long as this at least did not crash in OOO310m2.
Comment 15 Oliver-Rainer Wittmann 2009-03-10 12:16:02 UTC
defect cause:
While setting the text for the note object at the Outliner, a method
<Outliner::ImplCheckParagraphs( 0, (USHORT) (pParaList->GetParagraphCount()-1) )
is called without checking, if the count value is probably 0. Thus,
<Outliner::ImplCheckParagraphs(..)> is called with parameter value 0 and 65535,
which causes the for-loop in its implementation to loop forever.

solution:
Call method <Outliner::ImplCheckParagraphs(..)> without decrementing the count
value and adjust implementation of this method to assure its for-loop does not
loop forever.
Comment 16 max.odendahl 2009-03-10 12:41:09 UTC
mod->od: 

- why would this work in m2, but not in m4? Was there a recent change in this
regard?

- shouldn't this loop also happen then when importing an odt document and
setting the note object?

- so I guess the crash when saving the file is completly unrelated and needs a
seperate issue?
Comment 17 Oliver-Rainer Wittmann 2009-03-10 12:51:25 UTC
OD->MOD:

> - why would this work in m2, but not in m4? Was there a recent change in this
regard?
It seems that a change in cws aw063 at the Outliner causes this. But, I am not
sure. I will check this together with AW.

> - shouldn't this loop also happen then when importing an odt document and
setting the note object?
I do not know.

> - so I guess the crash when saving the file is completly unrelated and needs a
seperate issue?
I did not reproduce any crash.
Comment 18 Oliver-Rainer Wittmann 2009-03-10 12:59:25 UTC
fixed in cws sw31bf07 - change files:
/svx/source/outliner/outleeng.cxx
/svx/source/outliner/outliner.cxx
/svx/source/outliner/outlvw.cxx
rev. 269266
Comment 19 Oliver-Rainer Wittmann 2009-03-10 13:02:52 UTC
OD->MRU: Checked in internal installation set of cws sw31bf07 - please verify.
Comment 20 Oliver-Rainer Wittmann 2009-03-10 13:03:28 UTC
forgot to assign to MRU ;-)
Comment 21 michael.ruess 2009-03-11 13:56:12 UTC
Verified in CWS sw31bf07.
Comment 22 michael.ruess 2009-03-24 16:47:01 UTC
Checked in OOO310m7.