|
Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
| Summary: | Enable Persian Numbering support | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Internationalization | Reporter: | hamidi <hosseinhamidi> | ||||
| Component: | i18npool | Assignee: | frank | ||||
| Status: | CLOSED FIXED | QA Contact: | issues@l10n <issues> | ||||
| Severity: | Trivial | ||||||
| Priority: | P3 | CC: | farzaneh, issues | ||||
| Version: | OOo 2.2.1 | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Issue Type: | ENHANCEMENT | Latest Confirmation in: | --- | ||||
| Developer Difficulty: | --- | ||||||
| Issue Depends on: | |||||||
| Issue Blocks: | 96765 | ||||||
| Attachments: |
|
||||||
|
Description
hamidi
2007-07-19 15:58:20 UTC
SBA: This is an enhancement in the framework/i18n component.-> Changed issue type, component and summary accordingly. SBA->ER: As discussed, please proceed, thanks. These may actually be several different things. First, a native numbering using Persian digits instead of ASCII digits is not implemented. Then, are we talking also about numbering and outline numbering? For that, new constants would had to be added to offapi/com/sun/star/style/NumberingType.idl and LC_NumberingLevel and LC_OutLineNumberingLevel in i18npool/source/localedata/data/fa_IR.xml would had to be adapted. However, someone in the know would had to specify what types of numbering are actually used with Persian. Cc'ing 'farzanehs': Farzaneh, what are the plans about completing the support of Persian? Eike I have been working on it. I have a patch in hand that worked quite well when I tested it with 2.0.1. I will attach it here, but it needs to be ported on later versions. Created attachment 46962 [details]
Patch to add Persian native numbering for lists, page numbers, etc.
The above patch, as Eike has mentioned, also needs proper changes to the locale file, e. g. adding the NumType="37" as the NumberingLevels. (This patch sets CHARS_PERSIAN_LETTERS = 37.) Great! That patch looks good in general. Of course it needs adapting to current sources, e.g. the last style::NumberingType value used currently is 45, scheduling this for OOo2.4 Btw, I wonder why you didn't submit the patch earlier? Thanks Eike Thanks, Eike. I'll take some time to port it to the new sources. The reason I didn't submit it earlier was that I wasn't quite sure about its quality and I thought it still had room for improvement (not to mention my being busy with my just-accomplished Masters thesis.) Particularly, there are different numbering systems used in Iran that I thought would be useful to implement, and the letter numbering was still slightly buggy. Ready-for-QA before UI/feature freeze of OOo2.4 is nearing (next week). If the existing patch applies more or less (with minor corrections) neatly to the SRC680_m234 code base I'll include it. Otherwise I'll have to retarget this issue to 3.x. In cws locales24: offapi/com/sun/star/style/NumberingType.idl 1.16.196.1 i18npool/source/defaultnumberingprovider/defaultnumberingprovider.cxx 1.27.72.1 i18npool/source/nativenumber/nativenumbersupplier.cxx 1.24.102.1 i18npool/source/nativenumber/data/numberchar.h 1.12.118.1 Note that I renamed the API constant from CHARS_PERSIAN_LETTERS to CHARS_PERSIAN to match other usage of the CHARS_ prefix with/without LETTER. The value now is 46. Also slightly rearranged things in i18npool, no modification of bullet.h, table data added to defaultnumberingprovider.cxx @farzanehs: Adapting LC_NumberingLevel and LC_OutLineNumberingLevel is still pending, please submit a new issue with a patch for fa_IR.xml when ready. Thanks Eike Reassigning to QA for verification. found fixed on cws locales24 found integrated on master m239 |