Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
Summary: | gengal: Utility to generate OO.o gallery files | ||
---|---|---|---|
Product: | Draw | Reporter: | pmladek <pmladek> |
Component: | code | Assignee: | wolframgarten |
Status: | CLOSED FIXED | QA Contact: | issues@graphics <issues> |
Severity: | Trivial | ||
Priority: | P3 | CC: | issues, kami911, mmeeks, pavel |
Version: | 680m100 | ||
Target Milestone: | OOo 2.0.1 | ||
Hardware: | PC | ||
OS: | Linux, all | ||
Issue Type: | PATCH | Latest Confirmation in: | --- |
Developer Difficulty: | --- | ||
Attachments: |
Description
pmladek
2005-05-12 18:01:07 UTC
Created attachment 26071 [details]
The basic version of the utility
Created attachment 26072 [details]
This patch adds the --destdir option
Created attachment 26073 [details]
This patch adds the --number-from option instead of the uglu --num option. Also it cleans the shell wrapper.
Created attachment 26074 [details]
This patch allows to build gengal with gcc4
Reassigned. Please handle. Petr - the patch set looks a little confusing - even to me :-) Any chance you can re-generate it splitting it, so the patches are not incremental: ie. re-generate new files vs. /dev/null, and split out the pieces that patch the core code ? The core changes to svx/ are really rather trivial here, it's a shame to hide that fact :-) OK, I have re-merged the four patches and created another 3 patches that are not incremental. Created attachment 26193 [details]
This patch adds the new source file, wrapper and makefile
Created attachment 26194 [details]
This patch includes the necessary changes in the core code of the svx module
Created attachment 26195 [details]
This patch includes the necessary changes in the scp2 module
Is it currently part of official source or it will be part? kami - well of course I'd love to see this in 2.0.x - and since the core changes are really rather minimal / trivial - I don't see why that shouldn't happen. Re-targetting to 2.0.1 - hope that's ok. It'd be nice to have some up-stream comment. I will add this patch to OOo 2.0.1 in cws impress58 I can't build your patch, I get the following error when linking svx gengal.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) pu blic: static unsigned char __cdecl ucb::ContentBroker::initialize(class com::sun ::star::uno::Reference<class com::sun::star::lang::XMultiServiceFactory> const & ,class com::sun::star::uno::Sequence<class com::sun::star::uno::Any> const &)" ( __imp_?initialize@ContentBroker@ucb@@SAEABV?$Reference@VXMultiServiceFactory@lan g@star@sun@com@@@uno@star@sun@com@@ABV?$Sequence@VAny@uno@star@sun@com@@@4567@@Z ) referenced in function "public: virtual void __thiscall GalApp::Main(void)" (? Main@GalApp@@UAEXXZ) ..\..\wntmsci10\bin\gengal.bin.exe : fatal error LNK1120: 1 unresolved externals What milestone do you use for your build? Do you use gcc4 with the visibility feature? I use milestone m118 with windows non pro I imagine that the Win32 linker is more pernickerty about deps. Can you add $(UCBHELPERLIB) to the APP1STDLIBS in svx/source/gengal/makefile.mk and try again ? - I guess there may be a couple of other missing pieces in there too. Sorry for the pain - we don't see that on Linux. Ok that did it, I also had to change regcomp [blablabla] -c libfwl$(UPD)$(DLLSUFFIX)$(DLLPOST) \ -c libucpfile1$(DLLPOST) \ -c libfileacc$(DLLPOST) \ -c libucb1$(DLLPOST) to -c $(DLLPRE)fwl$(UPD)$(DLLSUFFIX)$(DLLPOST) \ -c $(DLLPRE)ucpfile1$(DLLPOST) \ -c $(DLLPRE)fileacc$(DLLPOST) \ -c $(DLLPRE)ucb1$(DLLPOST) a simple compile on at least one windows and one unix plattform for patches would be nice in the future. Anywhay, if this patch doesnt break any regression tests on my cws, consider it done for OOo 2.0.1 sources commited on branch for cws impress58 cool - thanks :-) Of course - with this utility in place, we can tweak a number of other things more easily: extending the web-export gallery stuff automatically, etc. and reduce our patch-set yet further which will be great. Thanks again. patch verified in cws. @cl->wg, please verify that our normal gallery feature is not harmed by this patch. Please test creation and handling of user themes and also drag'n'drop from to gallery. re-open issue and reassign to wg@openoffice.org reassign to wg@openoffice.org reset resolution to FIXED Verified in CWS. Closed. |