Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
Summary: | Progressive corruption of rotated images | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Impress | Reporter: | rgb <rgb.mldc> | ||||||
Component: | editing | Assignee: | AOO issues mailing list <issues> | ||||||
Status: | CLOSED FIXED | QA Contact: | |||||||
Severity: | Normal | ||||||||
Priority: | P3 | CC: | arielch, Armin.Le.Grand, issues, jsc | ||||||
Version: | 4.0.0-dev | Keywords: | regression | ||||||
Target Milestone: | 4.0.0 | Flags: | jsc:
4.0.0_release_blocker+
|
||||||
Hardware: | All | ||||||||
OS: | Unix, all | ||||||||
Issue Type: | DEFECT | Latest Confirmation in: | --- | ||||||
Developer Difficulty: | --- | ||||||||
Issue Depends on: | |||||||||
Issue Blocks: | 122836 | ||||||||
Attachments: |
|
Description
rgb
2013-07-16 08:50:52 UTC
ALG: Could not reproduce on Win7 or Mac, thus for now setting to Unix, all. Also could not reproduce on xubuntu 64bit with a fresh build (r1503264). Trying further. BTW: What ImageFormat is used to transport to presentation and PDF export? It's hold in the Metafile, but need to check the format. Evtl. it's a format for which we updated the suppurt library recently - and that on linux...? ALG: Can someone who can reproduce that please define exactly on what system this happens? ALG: Found after some debugging on linux. First, I could reproduce it, it's independent from #122753#. Reason is that the 1-bit mask added before the bitmap is rotated is *nit* innitialized under linux. Either this has changed in vcl or the X-implementation itself. Adding initialization to non-transparent (COL_BLACK) makes all work well. Preparing patch... Created attachment 81088 [details]
ALG: patch to add initialization to allocated mask
"alg" committed SVN revision 1503696 into trunk: i122758 Initialize Mask with non-transparent "alg" committed SVN revision 1503698 into branches/AOO400: i122758 integrated fix from trunk granted showstopper flag, fix available ALG: Is system-specific, on win mask-bitmaps with depth 1 get initialized, and on mac these are not even used. One more remark: The initial bitmap to start with had to be one *without* alpha channel; with alpha-channel this error would not have happened since adding a default one would not have been necessary. On AOO400m3(Build:9702) - Rev. 1503704 2013-07-11 12:55:09 (Thu, 11 Jul 2013) - Linux x86_64 downloaded from here: http://people.apache.org/~arielch/developer-snapshots/new/RC/4.0.0/binaries/es/ problem is NOT fixed. Picture gets quickly corrupted. Do I need to reopen the issue or the fix was not merged on this review? Ignore last comment. I did not realize that previous RC was still on memory when I installed the new one, so I get an hybrid monster that did not work. I confirm that on AOO400m3(Build:9702) - Rev. 1503704 2013-07-16 14:49:37 (Tue, 16 Jul 2013) - Linux x86_64 the fix is working. Sorry for the noise. Created attachment 81098 [details]
3.4.1 - 4.0.0 comparison
As a follow up of this, the same rotated image looks better in 3.4.1 than in 4.0.0
By better I mean that the image borders on 3.4.1 are more straight lines; and the image has more "pixelation" in 4.0.0 (compare Juliette Binoche's nose, and also the blue glass pearl mobile)
I have tested the new Linux RC from Ariel on Ubuntu and the described problem is fixed. But I agree that there is a regression with the border but that is a new issue from my perspective and should be fixed in the next version. In your comparison have you rotate the images exactly by the same degree? Andre mentioned that a slightly difference can result in a minor different viewing. Armin or Andre can tell us more ... ALG: Yes, a new task will be fine. The fallback has options for smoothing, but these seem not to be activated. Anyways, a better sys-level support for transformed bitmaps (as for Win and Mac, in vcl) would make this fallback, hand-transformed bitmaps obsolete... Wrote but 122778 for it. |