|
Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
| Summary: | update serf to new version 1.2.1 | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | General | Reporter: | jsc | ||||||||||
| Component: | code | Assignee: | Ariel Constenla-Haile <arielch> | ||||||||||
| Status: | CLOSED FIXED | QA Contact: | |||||||||||
| Severity: | Normal | ||||||||||||
| Priority: | P3 | CC: | arielch, hdu, issues, pescetti | ||||||||||
| Version: | 4.0.0-dev | ||||||||||||
| Target Milestone: | 4.0.0 | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | All | ||||||||||||
| Issue Type: | DEFECT | Latest Confirmation in: | --- | ||||||||||
| Developer Difficulty: | --- | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
jsc
2013-02-25 14:41:18 UTC
Created attachment 80357 [details]
Patch to update serf to 1.2.0
does it mean that you have the update already done? (In reply to comment #2) > does it mean that you have the update already done? It means it is a patch, only tested on Linux (but should work on the other platforms, too). Before breaking the build bots, it's better to test the patch on Windows before committing it (I can build on Win when I'm back home at the afternoon). ok perfect, I will test it on Mac MacOS seems to work, serf and ucb build at least. Will test the office tomorrow... Created attachment 80362 [details]
Win Patch
Windows patch for updating serf to 1.2.0
(Tested on Windows 7, 64 bits)
Created attachment 80363 [details]
Enable serf logging, on *nix
Logging goes to stderr, so enabled only on *nix when exporting ENABLE_SERF_LOGGING=YES
IMHO updating to serf 1.2.0 does not introduce (serious) regressions. Bug 121844 and bug 121845 seem to be discovered thanks to updating serf (instead of being caused by this update); in AOO 3.4.1 they are impossible to reproduce because serf does not work at all (in these two cases). Removing blocker status for bug 121202 (updating to serf solves some bug but not all of them), they should be investigated and fixed independently. "arielch" committed SVN revision 1452047 into trunk: i121823 - update serf to new version 1.2.0 Reusing this one for further update to 1.2.1 Created attachment 80843 [details]
Patch to update serf to 1.2.1
(In reply to Ariel Constenla-Haile from comment #12) > Created attachment 80843 [details] > Patch to update serf to 1.2.1 @jsc: can you try this on MacOS? I tried it on Linux/Windows and works fine. Looking at the change log at http://serf.googlecode.com/svn/tags/1.2.1/CHANGES and the release comment that it "fixes a number of bugs, including a pretty bad bug in digest authentication on a single, shared connection (issue 102)" this should be considered for inclusion into AOO 4.0.0 grant showstopper flag "arielch" committed SVN revision 1493303 into trunk: i121823 - Update serf to new version 1.2.1 It already got in but the issue status wasn't updated. (In reply to hdu@apache.org from comment #17) > It already got in but the issue status wasn't updated. blame it on the SVN Robot that forgot to remind me to do so. @jsc: release blocker flag has no sense on this bug, it will appear in the Bug List:"4.0.0_release_blocker+, Resolved", "normal" QA volunteer will have no idea how to verify this. it felt in my automatism, hdu checked, we have overseen that it was already integrated -> grant the flag to integrate ... we can just verify and close "hdu" committed SVN revision 1507291 into trunk: #i121823# the update to serf-1.2.* obsoleted the serf-1.0 tarball "hdu" committed SVN revision 1507305 into trunk: #i121823# the update to serf-1.2.* obsoleted the serf-1.1 tarball |