Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
Summary: | Inconsistent fill and line color across applications | ||
---|---|---|---|
Product: | General | Reporter: | Ariel Constenla-Haile <arielch> |
Component: | ui | Assignee: | Armin Le Grand <Armin.Le.Grand> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | Normal | ||
Priority: | P3 | CC: | issues |
Version: | 3.4.1 | ||
Target Milestone: | 4.0.0 | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | DEFECT | Latest Confirmation in: | --- |
Developer Difficulty: | --- |
Description
Ariel Constenla-Haile
2012-12-07 15:13:01 UTC
Assigning to the expert. @Armin: I just git grepped blue 8 nad found the svx/source/xoutdev/xpool.cxx:52 which seems to work [ariel@localhost main]$ git grep -n "153, *204, *255" binfilter/bf_sch/source/core/sch_chtmode2.cxx:837:/*N*/ aRowColors[7] = Color(153, 204, 255); binfilter/bf_svx/source/xoutdev/svx_xtabcolr.cxx:334:/*N*/ Insert(48, new XColorEntry( Color(153,204,255 ), aStr ) ); sd/source/core/drawdoc4.cxx:677: Any aBlue1( implMakeSolidCellStyle( pSSPool, OUString( RTL_CONSTASCII_USTRINGPARAM("blue1") ), aDefaultCellStyleName, RGB_COLORDATA(153,204 svx/source/xoutdev/xpool.cxx:52: const Color aNullFillCol(RGB_COLORDATA( 153, 204, 255 )); svx/source/xoutdev/xtabcolr.cxx:301: Insert(48, new XColorEntry( Color(153,204,255 ), aStr ) ); ALG: Taking a look... ALG: I see no reason why not to set the values used in SetDrawingLayerPoolDefaults() directly in XOutdevItemPool::XOutdevItemPool, it does anyways nothing else than changing these. Leaving it the way it is just leads to the possibility that modules might forget to call it :-/ It should have no drawbacks to load/asve, file formats or data exchange, but I need to ckeck this deeply... ALG: Filkeformat and exchange are okay, the defaults are part of ODF. Works as expected, comitting. "alg" committed SVN revision 1419491 into trunk: #121448# Aligned default fill color/ line style for all apps ALG: Okay, done. |