Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
Summary: | JDK7 : Replace generic type 46 with 49. | ||||||
---|---|---|---|---|---|---|---|
Product: | udk | Reporter: | Pedro Giffuni <pfg> | ||||
Component: | code | Assignee: | AOO issues mailing list <issues> | ||||
Status: | CLOSED FIXED | QA Contact: | |||||
Severity: | Normal | ||||||
Priority: | P3 | CC: | hdu | ||||
Version: | 3.4.0 Beta (OOo) | ||||||
Target Milestone: | 4.0.0 | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Issue Type: | DEFECT | Latest Confirmation in: | 3.4.1 | ||||
Developer Difficulty: | --- | ||||||
Attachments: |
|
Description
Pedro Giffuni
2012-09-25 15:59:08 UTC
Comment on attachment 79635 [details]
Replace the generic type in codemaker/javamaker
In file main/codemaker/source/javamaker/classfile.cxx
We use type 46 in function ClassFile::write(FileStream & file).
An alternative would be to use type 49 there which stands for Java5.
"hdu" committed SVN revision 1449622 into trunk: #i121098# use a classfile format compatible with at least JDK 5/6/7 Fixed with the commit above. Please review. Hmm ... The extra casting is good but I miss the reason for the decimal point in the #define and the complicated way of calculating 0 to multiply it. It does fix the issue though :). The naming of the major/minor version of classfile format comes straight from the JVM specification and the calculation of the two fields follows from it too. I see .. OK, thanks! |