Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
Summary: | [From Symphony] There is a memory leak in function SvxUnoDrawPool::~SvxUnoDrawPool() | ||||||
---|---|---|---|---|---|---|---|
Product: | performance | Reporter: | ChaoHuang <chao.dev.h> | ||||
Component: | www | Assignee: | zhang jianfang <zhangjf> | ||||
Status: | CLOSED FIXED | QA Contact: | |||||
Severity: | Normal | ||||||
Priority: | P3 | CC: | Armin.Le.Grand, issues, liushenf, zhangjf | ||||
Version: | AOO 3.4.0 | ||||||
Target Milestone: | 4.0.0 | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Issue Type: | DEFECT | Latest Confirmation in: | --- | ||||
Developer Difficulty: | --- | ||||||
Issue Depends on: | |||||||
Issue Blocks: | 120975, 121366 | ||||||
Attachments: |
|
Description
ChaoHuang
2012-06-14 16:07:37 UTC
The secondary pool created in function SvxUnoDrawPool::init() will not be released in function SvxUnoDrawPool::~SvxUnoDrawPool(). Need to free it explictly. Created attachment 78330 [details]
for file "main\svx\source\unodraw\unopool.cxx"
take over the bug to commit it's code. Committed to AOO trunk by revision 1351347. ALG: Unfortunately this leads to problems. When deleting the secondary pool first, it still has it's master set (pMaster) and asserts this. The correct way is to first delete the master pool (mpDefaultsPool) which rsets the pMaster at the pSecondaryPool, and then pSecondaryPool. See e.g. how SdrModel::~SdrModel destructs it's pool. Comitted as r1352830. (In reply to comment #5) > ALG: Unfortunately this leads to problems. When deleting the secondary pool > first, it still has it's master set (pMaster) and asserts this. The correct > way is to first delete the master pool (mpDefaultsPool) which rsets the > pMaster at the pSecondaryPool, and then pSecondaryPool. See e.g. how > SdrModel::~SdrModel destructs it's pool. > Comitted as r1352830. hi, Armin Thanks for your correction on the sequence. I learnt a lot in this mistake. You are a nice man. Suggest to put it into AOO 3.5.0 release |