Issue 119634

I am looking at this issue...

ALG: We do not (yet) support perspective shadow, except for 3D shapes. It's a missing feature.

Yes. But at least we want import the shadow color correctly.

Root cause: MS default shape shadow color(0x00808080, gray) is not consistent with  AOO Document shape shadow color(Black).
Resolution: When no shadow color property in MS shape(default), enforce a gray color for shape color when import.
Limitation: Some shadow in MS is not support by AOO. For them, current AOO behavior is importing them as the shadow AOO supports with distance 0 due to feature gap. In the fix, only shadow color is corrected.

Created attachment 79037 [details]
Patch for this issue

*** Issue 119563 has been marked as a duplicate of this issue. ***

@Oliver:
I have provided a patch to fix the default shadow color issue.
Now it is marked as 3.4.1 blocker and you have assigned it to yourself. What's meaning? Do you want to fix the issue totally(In AOO implement the unsupported shadow type which exists in MS) with this bug?

@Jianyuan Li:
Sorry, I have forgotten to write a corresponding comment.
I have taken over this issue to review your patch.
Afterwards, we can decide how to proceed.

@Oliver:
Do you have any comments for my patch/solution?
If no, please help commit the code. A long time has been past. Thanks.

I have assigned this issue to myself to indicate that I am volunteering to review the patch, because I am interested in this area. I have the review on my todo list. I expect that I will some resource this week to finish it.
Please stay tuned. Thx in advance.

Comment on attachment 79037 [details]
Patch for this issue

I finished my review of the patch.
The patch assures that the shadow color is set to the MS Word default one, as far as I can see.

As already stated, the patch is good for what it is intending.
For user this code change will have no visible effect - it still looks like as if the shadow is lost during import.

@Jianyuan Li: As we have a feature gap here regarding the shadow type, I propose to apply our default shadow distance in case such an unsupported shadow type is detected.
Is it possible to extend your patch?
If yes, please provide such an extended patch.

ALG: I agree with Oliver here, we should apply the AOO default shadow distance (it's 0,20cm to the bottom-right). To switch shadow on and have the correct shadow color but having no distance would be useless. It would render the invisible shadow and thus cost preformance ith no positive effect.

@Oliver & Armin,
I agree. I checked the default distance.
Presentation: Bottom -- 20cm  Right -- 20cm(0.08'')
Document & Spreadsheet: Bottom -- 30cm  Right -- 30cm(0.12'')
I want to use 30cm as default when import. Any comments?

Created attachment 79526 [details]
A complete patch containing the first patch

Please review the complete patch. In this patch, a default distance(0.12'') will be applied if the shadow type is not supported by AOO.

Actually there is a handling for unsupported shadow type distance before. I adjusted its position and did a little change.

taking over to review the patch

Comment on attachment 79037 [details]
Patch for this issue

replaced by new patch

An explanation for the patch:
AOO only support one kind of shadow type "shadowOffset". For others, AOO does not support. For MS shadow types(shadowDouble, shadowRich, shadowShape and so on), please refer to MS specification "[MS-ODRAW].pdf".

Comment on attachment 79526 [details]
A complete patch containing the first patch

review done.
patch looks good.
--> I will apply the patch on trunk.

applied patch on trunk, revision 1389406

verified on the build AOO3.5_r1391367

Update Target Milestone to AOO 3.5.0.