|
Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
| Summary: | [From Symphony] One shape's border cannot be displayed completely | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Impress | Reporter: | liuping <doneyourself> | ||||||||||
| Component: | open-import | Assignee: | AOO issues mailing list <issues> | ||||||||||
| Status: | CLOSED FIXED | QA Contact: | |||||||||||
| Severity: | Normal | ||||||||||||
| Priority: | P3 | CC: | awf.aoo, lijianyuan1983, liushenf | ||||||||||
| Version: | 3.4.0 | ||||||||||||
| Target Milestone: | 4.0.0 | ||||||||||||
| Hardware: | PC | ||||||||||||
| OS: | All | ||||||||||||
| Issue Type: | DEFECT | Latest Confirmation in: | --- | ||||||||||
| Developer Difficulty: | --- | ||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 77728 [details]
Capture.PNG
I am investigating this issue It is related to the issue 76201. Root cause: For the sample shape, there is an unnecessary command "ELLIPSETO" is found. Due to this command, a closed polygon turns into a open polypolygon(with two polygon, one is open and one is closed from code property view). Due to the open polygon, border is not rendered completely(a OBJ_PLIN SdrPathObj is created for render). Solution: The sample shape is so wired with a "ELLIPSETO" command. And the related segment is with 0 point. No segment is created for this command. If no segment is created, it will not be neccessary to divide the polygon into a polypolygon for command "ELLIPSETO". So when the points number for command is 0, do not end the last polygon. (In reply to comment #4) > Root cause: For the sample shape, there is an unnecessary command > "ELLIPSETO" is found. Due to this command, a closed polygon turns into a > open polypolygon(with two polygon, one is open and one is closed from code > property view). Due to the open polygon, border is not rendered completely(a > OBJ_PLIN SdrPathObj is created for render). > > Solution: The sample shape is so wired with a "ELLIPSETO" command. And the The command is "ANGLEELLIPSE" other than "ELLIPSETO" > related segment is with 0 point. No segment is created for this command. If > no segment is created, it will not be neccessary to divide the polygon into > a polypolygon for command "ELLIPSETO". So when the points number for command > is 0, do not end the last polygon. confirm this bug on rev 1327774 Created attachment 78538 [details]
Patch for this issue
Created attachment 78539 [details]
UT file for this issue
(In reply to comment #7) > Created attachment 78538 [details] > Patch for this issue The patch looks a little complicated. But actually only a condition "if ( nPntCount )" is added. "af" committed SVN revision 1359107: "#i119519# Fixed import of closed borders from PPT when an ellipse is involved. Reported by: liupingtan Patch by: Jianyuan Li Review by: Andre Fischer" Comment on attachment 78538 [details]
Patch for this issue
Reviewed and tested, OK.
Checked in that patch in SVN revision 1359107. Verified pass on Windows7-64bit, Redhat 32bit,ubutu 10.04 Mac10.7 with AOO trunk r1374181 |
Created attachment 77727 [details] sample file Build: rev 1327774 Steps: 1. Open the sample file in AOO and in MS 2. Check the shape border in page 1 Defect: Shape's border cannot be displayed completely pls refer the capture.png