|
Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
| Summary: | [From Symphony]The .xlsx sample file is opened with modified state | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Calc | Reporter: | Shan Zhu <shanzhu33> | ||||||
| Component: | open-import | Assignee: | Andre <awf.aoo> | ||||||
| Status: | CLOSED FIXED | QA Contact: | |||||||
| Severity: | Minor | ||||||||
| Priority: | P3 | CC: | awf.aoo, clarence.guo.bj, liushenf, polo8495 | ||||||
| Version: | 3.4.0 | ||||||||
| Target Milestone: | 4.0.0 | ||||||||
| Hardware: | PC | ||||||||
| OS: | All | ||||||||
| Issue Type: | DEFECT | Latest Confirmation in: | --- | ||||||
| Developer Difficulty: | --- | ||||||||
| Attachments: |
|
||||||||
Due to chart was set modified flag to true during loading. PPTX has the same problem. I'm working on this. Created attachment 78283 [details]
Add patch
Comment on attachment 78283 [details]
Add patch
Request Review
Root Cause: chart was set modify flag to true during loading. Solution: Reset all OLE's modify flag to false at the end of ImportFrom. It's the major filer method of MSOffice2010. As SD has the same problem(SW doesn't support import chart of MSOffice2010 yet), ImportFrom is the joint entry of the three applications, and MS2003 and ODF have no such problem, so it should the correct place to reset the flag. Reviewing. Comment on attachment 78283 [details] Add patch Reviewed. Patch looks good. Thanks for the good work. Applied on SVN revision 1349824. Forgot to update the issue status. Doing that now. Verify not fixed on trunk rev. 1350167, Reopen this bug. Platform is Win7 64 bit. @Terry: Very good that you caught that. I applied the patch at the wrong place. Probably because I did that manually (the patch had only partial path information). Fixed that by moving the patch to the right place (a couple of lines down in the same file.) SVN revision is 1351665. I am sorry for the inconvenience. Verify fixed on AOO 3.4.1 Dev Snapshot Builds Rev.1351712 Suggest close this bug. Close this bug set Target Milestone to AOO 3.5.0 for PM purpose. |
Created attachment 77686 [details] .xlsx Build info: AOO3.4_r1327774 Open the .xlsx sample file attached. Check the state of the Save button on toolbar. It will be enabled. Close the file without any change, a dialog will popup to ask whether you want to save the change.