Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
Summary: | [From Symphony]The image OLE's icon doesn't display correctly in Aoo3.4 | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Impress | Reporter: | Du Jing <bjdujing> | ||||||||||||
Component: | ui | Assignee: | AOO issues mailing list <issues> | ||||||||||||
Status: | CLOSED FIXED | QA Contact: | |||||||||||||
Severity: | Normal | ||||||||||||||
Priority: | P3 | CC: | Armin.Le.Grand, doneyourself, lijianyuan1983, liushenf, rb.henschel | ||||||||||||
Version: | 3.4.0 | ||||||||||||||
Target Milestone: | 4.0.0 | ||||||||||||||
Hardware: | PC | ||||||||||||||
OS: | All | ||||||||||||||
Issue Type: | DEFECT | Latest Confirmation in: | --- | ||||||||||||
Developer Difficulty: | --- | ||||||||||||||
Attachments: |
|
change its status~ I am investigating this issue. Root Cause: For emf file, there is one type named "alpha blend". But in our codes,we didn't translate this type, so its bitmaps will not be displayed. Resolution: According the format structure description in MSDN, translate this type, and get the image to display. Created attachment 78741 [details]
Patch for this issue
ALG: The sample file from description contains a Bitmap, not an OLE. Is this the wrong sample file? (In reply to comment #5) > ALG: The sample file from description contains a Bitmap, not an OLE. Is this > the wrong sample file? It is an OLE and can be activated. Please see the attachment "Actived OLE.jpg" Created attachment 78755 [details]
Activated OLE
Created attachment 78756 [details]
Screenshot of opened sample document from Description
ALG: Sorry, maybe I do not get it, but I see the following after opening the example and selecting the object with one mouse klick. It is a graphic object (see the toolbars shown). Doublecklicking will activate text input (text for graphic object).
How do You activate it as OLE...?
ALG: Tried to apply the patch, I get 'double value in switch' since EMR_ALPHABLEND is indeed double; it needs to be removed from the #ifdef WIN_MTF_ASSERT path to make the non-pro build work. It is an OLE object in Excel. But when you open the file in AOO, it is no longer an OLE object. I see the same problem with an MathType OLE in an xlsx-file. It is not imported as OLE but replaced with a picture. If I save it as xls in Excel and open that file in AOO, the OLE object is still an OLE object. I do not understand "The OLE's icon doesn't display correctly", but I think an OLE object should be imported as OLE object and not substituted by something. ALG: Thanks Regina. This looks like we first need to fix the .xlsx importer to cerate OLE2 (maybe done in Symphony?) before we can fix this task (?). ALG: Tried in Lotus Symphony 3 (Release 3.0.0 FP3), also imports as a graphic object. @Jianyuan Li: What did you use to import it as OLE? Which Office and which version? @Armin: Just as Regina said, it is an OLE in Excel. After it is imported in AOO/Symphony, it will become into a graphic. This is current situation for AOO/Symphony OLE import. It should be fixed later. But this will not impact the patch is checked in for this issue. Because this fix still works when the OLE is correctly imported. Please see sample file "Another OLE.xlsx". The OLE and its icon can be imported correctly by AOO. And its icon type is EMR_STRETCHBLT which is similar to EMR_ALPHABLEND. Created attachment 78758 [details]
UT file for this issue
"alg" committed SVN revision 1366403 into trunk: #119450# Added EMR_ALPHABLEND case to EnhWMFReader to correct visualisationsP... ALG: Thanks Jianyuan Li, I have now adapted the patch and built. With it, the graphic is shown as intended. Also looked at the code. Comitted change as revision 1366403, done. Thanks Armin and Regina. Verified pass on Windows7-64bit, Redhat 32bit,ubutu 10.04 Mac10.7 with AOO trunk r1374181 |
Created attachment 77634 [details] sample file Build Version: AOO3.4_1327774 Steps: 1. Open the sample file in AOO3.4 2. Check the OLE's icon in the document. Defect : The OLE's icon doesn't display correctly , only text can display.