Issue 101683

Summary: Shearing of CustomShapes is not working
Product: Draw Reporter: sven.jacobi
Component: codeAssignee: sven.jacobi
Status: CLOSED FIXED QA Contact: issues@graphics <issues>
Severity: Trivial    
Priority: P3 CC: issues, jes, rb.henschel
Version: DEV300m46   
Target Milestone: ---   
Hardware: All   
OS: All   
Issue Type: DEFECT Latest Confirmation in: ---
Developer Difficulty: ---
Issue Depends on: 55394    
Issue Blocks:    

Description sven.jacobi 2009-05-08 15:25:07 UTC
The shearing of CustomShapes should be allowed
Comment 1 sven.jacobi 2009-05-13 13:49:30 UTC
This issue has been fixed now in cws[impress171]
Comment 2 sven.jacobi 2009-06-04 10:10:45 UTC
sj->wg: shearing is now working also for customshapes, please verify.
Comment 3 wolframgarten 2009-06-05 10:00:56 UTC
Verified in CWS.
Comment 4 wolframgarten 2009-07-16 10:58:54 UTC
Tested in m52. Closed.
Comment 5 Joe Smith 2009-07-16 15:32:35 UTC
Verifying: I see correct behavior in DEV300_m52 (Linux), although vertical
shearing of a shape doesn't seem to work quite right.

If I create a custom shape, make a copy and convert it to a curve, then shear
both vertically, I get different results.

Shearing both horizontally gives the same result for both.

I suppose that's a new issue.
Comment 6 Regina Henschel 2009-07-16 15:57:46 UTC
Shearing is not correct, if you use the middle handles right and left.
Draw a rectangle from the classical kind and draw a rectangle from the custom
shapes.
Bring them into rotate mode, so that you have red handles.
Drag the right one up and down.

Both rectangle should behave same, but the shape rectangle acts wrong.
Comment 7 wolframgarten 2009-07-21 08:55:56 UTC
Reproducible. Reassigned.
Comment 8 sven.jacobi 2009-09-28 11:29:36 UTC
changed target
Comment 9 Regina Henschel 2010-03-02 15:52:39 UTC
I have added a patch to issue 55394, which includes a corrected NbcShear for
this issue here. Shearing in y-direction is correctly done by the inherited
method, there is no need for rotating back- and forward. But shearing might
induce a rotation, so fObjectRotation needs an update.
Comment 10 Regina Henschel 2012-12-27 16:25:29 UTC
Fixed together with bug 55394 on trunk with commit r1420199.
Comment 11 Joe Smith 2013-07-13 14:35:22 UTC
Testing
AOO400m3(Build:9702)  -  Rev. 1502185
2013-07-11 08:22:42 (Thu, 11 Jul 2013) - Linux i686
on Fedora 17

Vertical shearing of smart shape looks correct now.

Thank you so much!