Index: org/apache/jetspeed/cache/disk/DiskCacheUtils.java =================================================================== RCS file: /home/cvspublic/jakarta-jetspeed/src/java/org/apache/jetspeed/cache/disk/DiskCacheUtils.java,v retrieving revision 1.17 diff -u -r1.17 DiskCacheUtils.java --- org/apache/jetspeed/cache/disk/DiskCacheUtils.java 13 Sep 2001 17:52:18 -0000 1.17 +++ org/apache/jetspeed/cache/disk/DiskCacheUtils.java 4 May 2003 21:42:42 -0000 @@ -55,15 +55,17 @@ package org.apache.jetspeed.cache.disk; //jetspeed -import org.apache.jetspeed.util.*; +import org.apache.jetspeed.util.URIEncoder; //standard java stuff -import java.io.*; -import java.net.*; -import java.util.*; +import java.io.File; +import java.net.MalformedURLException; +import java.net.URL; +import java.util.Enumeration; +import java.util.Vector; //turbine -import org.apache.turbine.util.*; +import org.apache.turbine.util.Log; import org.apache.turbine.services.servlet.TurbineServlet; import org.apache.jetspeed.services.resources.JetspeedResources; Index: org/apache/jetspeed/cache/disk/JetspeedDiskCache.java =================================================================== RCS file: /home/cvspublic/jakarta-jetspeed/src/java/org/apache/jetspeed/cache/disk/JetspeedDiskCache.java,v retrieving revision 1.47 diff -u -r1.47 JetspeedDiskCache.java --- org/apache/jetspeed/cache/disk/JetspeedDiskCache.java 4 Mar 2003 00:04:51 -0000 1.47 +++ org/apache/jetspeed/cache/disk/JetspeedDiskCache.java 4 May 2003 21:42:42 -0000 @@ -1,7 +1,7 @@ /* ==================================================================== * The Apache Software License, Version 1.1 * - * Copyright (c) 2000-2001 The Apache Software Foundation. All rights + * Copyright (c) 2000-2003 The Apache Software Foundation. All rights * reserved. * * Redistribution and use in source and binary forms, with or without @@ -55,7 +55,7 @@ package org.apache.jetspeed.cache.disk; //jetspeed -import org.apache.jetspeed.util.*; +import org.apache.jetspeed.util.URIEncoder; import org.apache.jetspeed.services.threadpool.ThreadPool; import org.apache.jetspeed.services.urlmanager.URLManager; import org.apache.jetspeed.services.urlmanager.URLFetcher; @@ -63,13 +63,19 @@ import org.apache.jetspeed.services.resources.JetspeedResources; //standard java stuff -import java.io.*; -import java.net.*; -import java.util.*; -import javax.servlet.*; +import java.io.File; +import java.io.FileOutputStream; +import java.io.IOException; +import java.io.Reader; +import java.io.OutputStreamWriter; +import java.net.MalformedURLException; +import java.util.Enumeration; +import java.util.Hashtable; +import java.util.Vector; +import javax.servlet.ServletContext; //turbine -import org.apache.turbine.util.*; +import org.apache.turbine.util.Log; import org.apache.turbine.services.servlet.TurbineServlet; @@ -118,14 +124,20 @@ try { ServletContext sc = TurbineServlet.getServletContext(); tempdir = sc.getAttribute("javax.servlet.context.tempdir").toString() + "/jetspeed/cache"; - Log.debug("DISK CACHE: will create cache in servlet temp directory " + tempdir); + if ( Log.getLogger().isDebugEnabled() ) + { + Log.debug("DISK CACHE: will create cache in servlet temp directory " + tempdir); + } } catch (Exception e) { Log.error("DISK CACHE: problems creating cache in servlet temp directory " + " falling back to WEB-INF/cache : " + e); } this.directory = tempdir; } else { - Log.debug("DISK CACHE: will use cache in user configured directory " + directory); + if ( Log.getLogger().isDebugEnabled() ) + { + Log.debug("DISK CACHE: will use cache in user configured directory " + directory); + } } } @@ -150,7 +162,11 @@ org.apache.turbine.services.TurbineServices .getInstance() .getService( org.apache.jetspeed.services.urlmanager.URLManagerService.SERVICE_NAME ).init(); - } catch (Throwable t) {} + } + catch (Throwable t) + { + Log.error( "initEntries: Unable to start URLManagerService", t ); + } File temp = new File( directory ); Index: org/apache/jetspeed/cache/disk/JetspeedDiskCacheEntry.java =================================================================== RCS file: /home/cvspublic/jakarta-jetspeed/src/java/org/apache/jetspeed/cache/disk/JetspeedDiskCacheEntry.java,v retrieving revision 1.30 diff -u -r1.30 JetspeedDiskCacheEntry.java --- org/apache/jetspeed/cache/disk/JetspeedDiskCacheEntry.java 17 Jan 2002 11:32:33 -0000 1.30 +++ org/apache/jetspeed/cache/disk/JetspeedDiskCacheEntry.java 4 May 2003 21:42:43 -0000 @@ -1,7 +1,7 @@ /* ==================================================================== * The Apache Software License, Version 1.1 * - * Copyright (c) 2000-2001 The Apache Software Foundation. All rights + * Copyright (c) 2000-2003 The Apache Software Foundation. All rights * reserved. * * Redistribution and use in source and binary forms, with or without @@ -391,6 +391,9 @@ String localfile = this.getURL().substring(5); //remove "file:" this.lastModified = new File( localfile ).lastModified(); } catch ( Exception e ) { + if( Log.getLogger().isDebugEnabled() ) { + Log.debug("Error getLastModified ", e); + } e.printStackTrace(); } } Index: org/apache/jetspeed/daemon/DaemonThread.java =================================================================== RCS file: /home/cvspublic/jakarta-jetspeed/src/java/org/apache/jetspeed/daemon/DaemonThread.java,v retrieving revision 1.17 diff -u -r1.17 DaemonThread.java --- org/apache/jetspeed/daemon/DaemonThread.java 4 Mar 2003 00:04:51 -0000 1.17 +++ org/apache/jetspeed/daemon/DaemonThread.java 4 May 2003 21:42:44 -0000 @@ -1,7 +1,7 @@ /* ==================================================================== * The Apache Software License, Version 1.1 * - * Copyright (c) 2000-2001 The Apache Software Foundation. All rights + * Copyright (c) 2000-2003 The Apache Software Foundation. All rights * reserved. * * Redistribution and use in source and binary forms, with or without @@ -54,7 +54,7 @@ package org.apache.jetspeed.daemon; -import org.apache.turbine.util.*; +import org.apache.turbine.util.Log; import org.apache.jetspeed.services.daemonfactory.DaemonFactory; Index: org/apache/jetspeed/daemon/impl/BadURLManagerDaemon.java =================================================================== RCS file: /home/cvspublic/jakarta-jetspeed/src/java/org/apache/jetspeed/daemon/impl/BadURLManagerDaemon.java,v retrieving revision 1.11 diff -u -r1.11 BadURLManagerDaemon.java --- org/apache/jetspeed/daemon/impl/BadURLManagerDaemon.java 4 Mar 2003 00:04:51 -0000 1.11 +++ org/apache/jetspeed/daemon/impl/BadURLManagerDaemon.java 4 May 2003 21:42:44 -0000 @@ -1,7 +1,7 @@ /* ==================================================================== * The Apache Software License, Version 1.1 * - * Copyright (c) 2000-2001 The Apache Software Foundation. All rights + * Copyright (c) 2000-2003 The Apache Software Foundation. All rights * reserved. * * Redistribution and use in source and binary forms, with or without @@ -55,17 +55,20 @@ package org.apache.jetspeed.daemon.impl; //jetspeed stuff -import org.apache.jetspeed.daemon.*; -import org.apache.jetspeed.cache.disk.*; +import org.apache.jetspeed.daemon.Daemon; +import org.apache.jetspeed.daemon.DaemonConfig; +import org.apache.jetspeed.daemon.DaemonEntry; +import org.apache.jetspeed.cache.disk.DiskCacheUtils; +import org.apache.jetspeed.cache.disk.JetspeedDiskCache; import org.apache.jetspeed.services.urlmanager.URLManager; import org.apache.jetspeed.services.urlmanager.URLFetcher; //java stuff -import java.io.*; +import java.io.IOException; import java.util.Iterator; //turbine stuff -import org.apache.turbine.util.*; +import org.apache.turbine.util.Log; /** Manages pulling URLs from the BadURLManager, and if they are available, removing Index: org/apache/jetspeed/daemon/impl/DiskCacheDaemon.java =================================================================== RCS file: /home/cvspublic/jakarta-jetspeed/src/java/org/apache/jetspeed/daemon/impl/DiskCacheDaemon.java,v retrieving revision 1.20 diff -u -r1.20 DiskCacheDaemon.java --- org/apache/jetspeed/daemon/impl/DiskCacheDaemon.java 4 Mar 2003 00:04:51 -0000 1.20 +++ org/apache/jetspeed/daemon/impl/DiskCacheDaemon.java 4 May 2003 21:42:44 -0000 @@ -1,7 +1,7 @@ /* ==================================================================== * The Apache Software License, Version 1.1 * - * Copyright (c) 2000-2001 The Apache Software Foundation. All rights + * Copyright (c) 2000-2003 The Apache Software Foundation. All rights * reserved. * * Redistribution and use in source and binary forms, with or without @@ -55,13 +55,17 @@ package org.apache.jetspeed.daemon.impl; //jetspeed stuff -import org.apache.jetspeed.daemon.*; -import org.apache.jetspeed.daemon.impl.util.diskcachedaemon.*; -import org.apache.jetspeed.cache.disk.*; +import org.apache.jetspeed.daemon.Daemon; +import org.apache.jetspeed.daemon.DaemonConfig; +import org.apache.jetspeed.daemon.DaemonEntry; +import org.apache.jetspeed.daemon.impl.util.diskcachedaemon.URLRefresher; +import org.apache.jetspeed.cache.disk.DiskCacheEntry; +import org.apache.jetspeed.cache.disk.JetspeedDiskCache; import org.apache.jetspeed.services.threadpool.ThreadPool; //turbine stuff -import org.apache.turbine.util.*; +import org.apache.turbine.util.Log; +import org.apache.turbine.util.RunData; /** A daemon that takes all instances of the DiskCacheDaemon and makes sure Index: org/apache/jetspeed/daemon/impl/FeedDaemon.java =================================================================== RCS file: /home/cvspublic/jakarta-jetspeed/src/java/org/apache/jetspeed/daemon/impl/FeedDaemon.java,v retrieving revision 1.38 diff -u -r1.38 FeedDaemon.java --- org/apache/jetspeed/daemon/impl/FeedDaemon.java 4 Mar 2003 00:04:51 -0000 1.38 +++ org/apache/jetspeed/daemon/impl/FeedDaemon.java 4 May 2003 21:42:45 -0000 @@ -1,7 +1,7 @@ /* ==================================================================== * The Apache Software License, Version 1.1 * - * Copyright (c) 2000-2001 The Apache Software Foundation. All rights + * Copyright (c) 2000-2003 The Apache Software Foundation. All rights * reserved. * * Redistribution and use in source and binary forms, with or without @@ -56,19 +56,22 @@ //jetspeed stuff -import org.apache.jetspeed.daemon.*; -import org.apache.jetspeed.util.*; +import org.apache.jetspeed.daemon.Daemon; +import org.apache.jetspeed.daemon.DaemonConfig; +import org.apache.jetspeed.daemon.DaemonEntry; +import org.apache.jetspeed.daemon.Feed; +import org.apache.jetspeed.util.SimpleTransform; import org.apache.jetspeed.services.resources.JetspeedResources; import org.apache.jetspeed.services.registry.FileRegistry; import org.apache.jetspeed.services.registry.RegistryService; //turbine stuff -import org.apache.turbine.util.*; +import org.apache.turbine.util.Log; import org.apache.turbine.services.TurbineServices; //java stuff -import java.io.*; -import java.util.*; +import java.io.Reader; +import java.util.Vector; /**

Index: org/apache/jetspeed/daemon/impl/util/ThreadGroupJoin.java =================================================================== RCS file: /home/cvspublic/jakarta-jetspeed/src/java/org/apache/jetspeed/daemon/impl/util/ThreadGroupJoin.java,v retrieving revision 1.6 diff -u -r1.6 ThreadGroupJoin.java --- org/apache/jetspeed/daemon/impl/util/ThreadGroupJoin.java 17 Dec 2001 15:32:24 -0000 1.6 +++ org/apache/jetspeed/daemon/impl/util/ThreadGroupJoin.java 4 May 2003 21:42:45 -0000 @@ -1,7 +1,7 @@ /* ==================================================================== * The Apache Software License, Version 1.1 * - * Copyright (c) 2000-2001 The Apache Software Foundation. All rights + * Copyright (c) 2000-2003 The Apache Software Foundation. All rights * reserved. * * Redistribution and use in source and binary forms, with or without @@ -54,7 +54,7 @@ package org.apache.jetspeed.daemon.impl.util; -import org.apache.turbine.util.*; +import org.apache.turbine.util.Log; /** Util class for joining a ThreadGroup and joining all of its Threads and waiting @@ -113,8 +113,11 @@ long seconds = ( System.currentTimeMillis() - begin ) / 1000; begin = System.currentTimeMillis(); - - Log.info( source + ": has completed " + i + " threads in " + seconds + " second(s)" ); + + if ( Log.getLogger().isInfoEnabled() ) + { + Log.info( source + ": has completed " + i + " threads in " + seconds + " second(s)" ); + } } Index: org/apache/jetspeed/daemon/impl/util/diskcachedaemon/URLRefresher.java =================================================================== RCS file: /home/cvspublic/jakarta-jetspeed/src/java/org/apache/jetspeed/daemon/impl/util/diskcachedaemon/URLRefresher.java,v retrieving revision 1.13 diff -u -r1.13 URLRefresher.java --- org/apache/jetspeed/daemon/impl/util/diskcachedaemon/URLRefresher.java 4 Mar 2003 00:04:52 -0000 1.13 +++ org/apache/jetspeed/daemon/impl/util/diskcachedaemon/URLRefresher.java 4 May 2003 21:42:45 -0000 @@ -1,7 +1,7 @@ /* ==================================================================== * The Apache Software License, Version 1.1 * - * Copyright (c) 2000-2001 The Apache Software Foundation. All rights + * Copyright (c) 2000-2003 The Apache Software Foundation. All rights * reserved. * * Redistribution and use in source and binary forms, with or without @@ -60,10 +60,10 @@ import org.apache.jetspeed.services.urlmanager.URLFetcher; //turbine stuff -import org.apache.turbine.util.*; +import org.apache.turbine.util.Log; //Java stuff -import java.util.*; +import java.util.Enumeration; /**

Index: org/apache/jetspeed/daemon/impl/util/feeddaemon/EntryInstantiator.java =================================================================== RCS file: /home/cvspublic/jakarta-jetspeed/src/java/org/apache/jetspeed/daemon/impl/util/feeddaemon/EntryInstantiator.java,v retrieving revision 1.13 diff -u -r1.13 EntryInstantiator.java --- org/apache/jetspeed/daemon/impl/util/feeddaemon/EntryInstantiator.java 4 Mar 2003 00:04:52 -0000 1.13 +++ org/apache/jetspeed/daemon/impl/util/feeddaemon/EntryInstantiator.java 4 May 2003 21:42:45 -0000 @@ -1,7 +1,7 @@ /* ==================================================================== * The Apache Software License, Version 1.1 * - * Copyright (c) 2000-2001 The Apache Software Foundation. All rights + * Copyright (c) 2000-2003 The Apache Software Foundation. All rights * reserved. * * Redistribution and use in source and binary forms, with or without @@ -60,7 +60,7 @@ import org.apache.jetspeed.om.registry.PortletEntry; //turbine stuff -import org.apache.turbine.util.*; +import org.apache.turbine.util.Log; /** Handles taking all known Portlets and then instantiatles them all so that @@ -83,10 +83,13 @@ public void process() { - Log.info( "BEGIN: EntryInstantiator: Instantiating " + + if ( Log.getLogger().isInfoEnabled() ) + { + Log.info( "BEGIN: EntryInstantiator: Instantiating " + Registry.get(Registry.PORTLET).getEntryCount() + " Portlet(s) found in the PortletRegistry" ); - + } + for( int i = 0; i < entries.length; ++i ) { Instantiator inst = new Instantiator( i, entries[i] ); Index: org/apache/jetspeed/daemon/impl/util/feeddaemon/Instantiator.java =================================================================== RCS file: /home/cvspublic/jakarta-jetspeed/src/java/org/apache/jetspeed/daemon/impl/util/feeddaemon/Instantiator.java,v retrieving revision 1.23 diff -u -r1.23 Instantiator.java --- org/apache/jetspeed/daemon/impl/util/feeddaemon/Instantiator.java 4 Mar 2003 00:04:52 -0000 1.23 +++ org/apache/jetspeed/daemon/impl/util/feeddaemon/Instantiator.java 4 May 2003 21:42:45 -0000 @@ -1,7 +1,7 @@ /* ==================================================================== * The Apache Software License, Version 1.1 * - * Copyright (c) 2000-2001 The Apache Software Foundation. All rights + * Copyright (c) 2000-2003 The Apache Software Foundation. All rights * reserved. * * Redistribution and use in source and binary forms, with or without @@ -55,7 +55,8 @@ package org.apache.jetspeed.daemon.impl.util.feeddaemon; //jetspeed stuff -import org.apache.jetspeed.cache.disk.*; +import org.apache.jetspeed.cache.disk.DiskCacheUtils; +import org.apache.jetspeed.cache.disk.JetspeedDiskCache; import org.apache.jetspeed.om.registry.PortletEntry; import org.apache.jetspeed.services.Registry; import org.apache.jetspeed.services.PortletFactory; @@ -65,10 +66,10 @@ import org.apache.jetspeed.services.resources.JetspeedResources; //turbine stuff -import org.apache.turbine.util.*; +import org.apache.turbine.util.Log; //Java stuff -import java.io.*; +import java.io.IOException; /**

@@ -192,7 +193,7 @@ return; } catch ( Throwable t) { //t.printStackTrace(); - Log.error( "Instantiator: Throwable" + t); + Log.error( "Instantiator: Throwable", t); } org.apache.jetspeed.om.registry.Registry registry = Index: org/apache/jetspeed/modules/ParameterLoader.java =================================================================== RCS file: /home/cvspublic/jakarta-jetspeed/src/java/org/apache/jetspeed/modules/ParameterLoader.java,v retrieving revision 1.2 diff -u -r1.2 ParameterLoader.java --- org/apache/jetspeed/modules/ParameterLoader.java 27 Nov 2002 17:56:38 -0000 1.2 +++ org/apache/jetspeed/modules/ParameterLoader.java 4 May 2003 21:42:46 -0000 @@ -87,11 +87,6 @@ private static ParameterLoader instance = new ParameterLoader(JetspeedResources.getInt("parameter.cache.size", 50)); /** - * Logging verbosity level for debug statements (the higher the more output) - */ - private static int verbosity = JetspeedResources.getInt("parameter.verbosity", 1); - - /** * These ctor's are private to force clients to use getInstance() * to access this class. */ @@ -183,8 +178,8 @@ if (cache() && this.containsKey(provider)) { prm = (ParameterPresentationStyle) this.get(provider); - if (verbosity > 0 && Log.getLogger().isDebugEnabled()) { - Log.debug("ParameterLoader: Serving parameter: "+provider+", prm="+prm+" from cache"); + if ( Log.getLogger().isDebugEnabled() ) { + Log.debug("ParameterLoader: Serving parameter: " + provider + ", prm=" + prm + " from cache"); } } else { @@ -198,17 +193,18 @@ // Attempt to load the presentation style prm = (ParameterPresentationStyle)ab.getAssembler("parameter", provider); if (prm == null) { - if (verbosity > 0 && Log.getLogger().isDebugEnabled()) { + if ( Log.getLogger().isDebugEnabled() ) { Log.debug("ParameterLoader: Registering the factory"); } ab.registerFactory("parameter", new ParameterPresentationStyleFactory()); prm = (ParameterPresentationStyle)ab.getAssembler("parameter", provider); } - if (verbosity > 0 && Log.getLogger().isDebugEnabled()) { + if ( Log.getLogger().isDebugEnabled() ) { Log.debug("ParameterLoader: Loaded parameter: "+provider+", prm="+prm); } } catch (ClassCastException cce) { prm = null; + Log.error( "Error loading presentation style", cce ); } if (prm == null) { @@ -260,7 +256,7 @@ if (parmkey.startsWith(key)) { try { String stylekey = parmkey.substring(parmkey.lastIndexOf(".")+1); - if (verbosity > 1 && Log.getLogger().isDebugEnabled()) + if ( Log.getLogger().isDebugEnabled() ) { Log.debug("ParameterLoader: parm name [" + parmName + "] - storing option [" + stylekey + "] with value [" + parms.get(parmkey) + "]"); Index: org/apache/jetspeed/modules/actions/JetspeedAccessController.java =================================================================== RCS file: /home/cvspublic/jakarta-jetspeed/src/java/org/apache/jetspeed/modules/actions/JetspeedAccessController.java,v retrieving revision 1.6 diff -u -r1.6 JetspeedAccessController.java --- org/apache/jetspeed/modules/actions/JetspeedAccessController.java 4 Mar 2003 00:04:52 -0000 1.6 +++ org/apache/jetspeed/modules/actions/JetspeedAccessController.java 4 May 2003 21:42:46 -0000 @@ -1,7 +1,7 @@ /* ==================================================================== * The Apache Software License, Version 1.1 * - * Copyright (c) 2000-2001 The Apache Software Foundation. All rights + * Copyright (c) 2000-2003 The Apache Software Foundation. All rights * reserved. * * Redistribution and use in source and binary forms, with or without @@ -88,7 +88,7 @@ catch (ClassCastException e) { Log.error("The RunData object does not implement the expected interface, " - +"please verify the RunData factory settings"); + + "please verify the RunData factory settings", e); return; } Index: org/apache/jetspeed/modules/actions/JetspeedSessionValidator.java =================================================================== RCS file: /home/cvspublic/jakarta-jetspeed/src/java/org/apache/jetspeed/modules/actions/JetspeedSessionValidator.java,v retrieving revision 1.22 diff -u -r1.22 JetspeedSessionValidator.java --- org/apache/jetspeed/modules/actions/JetspeedSessionValidator.java 8 Apr 2003 21:35:30 -0000 1.22 +++ org/apache/jetspeed/modules/actions/JetspeedSessionValidator.java 4 May 2003 21:42:46 -0000 @@ -1,7 +1,7 @@ /* ==================================================================== * The Apache Software License, Version 1.1 * - * Copyright (c) 2000-2001 The Apache Software Foundation. All rights + * Copyright (c) 2000-2003 The Apache Software Foundation. All rights * reserved. * * Redistribution and use in source and binary forms, with or without @@ -69,6 +69,7 @@ import org.apache.jetspeed.util.ServiceUtil; import org.apache.jetspeed.services.customlocalization.CustomLocalizationService; + /** Just like org.apache.turbine.modules.actions.sessionvalidator.TemplateSessionValidator except: