From 42985e628cf29fa82599a3cf9ddca0a77f281723 Mon Sep 17 00:00:00 2001 From: Prabhu Joseph Date: Tue, 8 Oct 2019 13:06:20 +0530 Subject: [PATCH] YARN-9874. Remove unnecessary LevelDb write call in LeveldbConfigurationStore#confirmMutation. --- .../scheduler/capacity/conf/LeveldbConfigurationStore.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/conf/LeveldbConfigurationStore.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/conf/LeveldbConfigurationStore.java index 743d7ef..59d6c49 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/conf/LeveldbConfigurationStore.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/conf/LeveldbConfigurationStore.java @@ -203,8 +203,8 @@ public void logMutation(LogMutation logMutation) throws IOException { @Override public void confirmMutation(boolean isValid) throws IOException { - WriteBatch updateBatch = db.createWriteBatch(); if (isValid) { + WriteBatch updateBatch = db.createWriteBatch(); for (Map.Entry changes : pendingMutation.getUpdates().entrySet()) { if (changes.getValue() == null || changes.getValue().isEmpty()) { @@ -213,8 +213,8 @@ public void confirmMutation(boolean isValid) throws IOException { updateBatch.put(bytes(changes.getKey()), bytes(changes.getValue())); } } + db.write(updateBatch); } - db.write(updateBatch); pendingMutation = null; } -- 2.7.4 (Apple Git-66)