From a2ee28a265f948921fe630c51e932f2da4d16b31 Mon Sep 17 00:00:00 2001 From: Wellington Chevreuil Date: Wed, 18 Sep 2019 17:26:03 +0100 Subject: [PATCH] HBASE-23047 - ChecksumUtil.validateChecksum logs an INFO message inside a "if(LOG.isTraceEnabled())" block. --- .../org/apache/hadoop/hbase/io/hfile/ChecksumUtil.java | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/ChecksumUtil.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/ChecksumUtil.java index dc007f726a..f2f9d58796 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/ChecksumUtil.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/ChecksumUtil.java @@ -180,12 +180,10 @@ public class ChecksumUtil { DataChecksum.newDataChecksum(ctype.getDataChecksumType(), bytesPerChecksum); assert dataChecksum != null; int onDiskDataSizeWithHeader = - buf.getInt(HFileBlock.Header.ON_DISK_DATA_SIZE_WITH_HEADER_INDEX); - if (LOG.isTraceEnabled()) { - LOG.info("dataLength=" + buf.capacity() + ", sizeWithHeader=" + onDiskDataSizeWithHeader - + ", checksumType=" + ctype.getName() + ", file=" + pathName + ", offset=" + offset - + ", headerSize=" + hdrSize + ", bytesPerChecksum=" + bytesPerChecksum); - } + buf.getInt(HFileBlock.Header.ON_DISK_DATA_SIZE_WITH_HEADER_INDEX); + LOG.trace("dataLength={}, sizeWithHeader={}, checksumType={}, file={}, " + + "offset={}, headerSize={}, bytesPerChecksum={}", buf.capacity(), onDiskDataSizeWithHeader, + ctype.getName(), pathName, offset, hdrSize, bytesPerChecksum); ByteBuff data = buf.duplicate().position(0).limit(onDiskDataSizeWithHeader); ByteBuff checksums = buf.duplicate().position(onDiskDataSizeWithHeader).limit(buf.limit()); return verifyChunkedSums(dataChecksum, data, checksums, pathName); -- 2.17.2 (Apple Git-113)