From 852bb0255143fce81c800aa562abab5e0e0476e5 Mon Sep 17 00:00:00 2001 From: Wellington Chevreuil Date: Wed, 18 Sep 2019 17:26:03 +0100 Subject: [PATCH] HBASE-23047 - ChecksumUtil.validateChecksum logs an INFO message inside a "if(LOG.isTraceEnabled())" block. --- .../org/apache/hadoop/hbase/io/hfile/ChecksumUtil.java | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/ChecksumUtil.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/ChecksumUtil.java index dc007f726a..885e0af6b0 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/ChecksumUtil.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/ChecksumUtil.java @@ -181,11 +181,9 @@ public class ChecksumUtil { assert dataChecksum != null; int onDiskDataSizeWithHeader = buf.getInt(HFileBlock.Header.ON_DISK_DATA_SIZE_WITH_HEADER_INDEX); - if (LOG.isTraceEnabled()) { - LOG.info("dataLength=" + buf.capacity() + ", sizeWithHeader=" + onDiskDataSizeWithHeader - + ", checksumType=" + ctype.getName() + ", file=" + pathName + ", offset=" + offset - + ", headerSize=" + hdrSize + ", bytesPerChecksum=" + bytesPerChecksum); - } + LOG.trace("dataLength={}, sizeWithHeader={}, checksumType={}, file={}, offset={}, " + + "headerSize={}, bytesPerChecksum={}", buf.capacity(), onDiskDataSizeWithHeader, + ctype.getName(), pathName, offset, hdrSize, bytesPerChecksum); ByteBuff data = buf.duplicate().position(0).limit(onDiskDataSizeWithHeader); ByteBuff checksums = buf.duplicate().position(onDiskDataSizeWithHeader).limit(buf.limit()); return verifyChunkedSums(dataChecksum, data, checksums, pathName); -- 2.17.2 (Apple Git-113)