From 924fb8165f950ecca9967f1fb58019d74aa52346 Mon Sep 17 00:00:00 2001 From: Vladimir Rodionov Date: Wed, 27 Mar 2019 15:09:03 -0700 Subject: [PATCH] HBASE-22075: Potential data loss when MOB compaction fails --- .../hbase/mob/compactions/PartitionedMobCompactor.java | 6 ------ 1 file changed, 6 deletions(-) diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/mob/compactions/PartitionedMobCompactor.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/mob/compactions/PartitionedMobCompactor.java index 9f1ab965a1..a6e84abc20 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/mob/compactions/PartitionedMobCompactor.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/mob/compactions/PartitionedMobCompactor.java @@ -621,7 +621,6 @@ public class PartitionedMobCompactor extends MobCompactor { long mobCells = 0; boolean cleanupTmpMobFile = false; boolean cleanupBulkloadDirOfPartition = false; - boolean cleanupCommittedMobFile = false; boolean closeReaders= true; try { @@ -673,10 +672,8 @@ public class PartitionedMobCompactor extends MobCompactor { // commit mob file MobUtils.commitFile(conf, fs, filePath, mobFamilyDir, compactionCacheConfig); cleanupTmpMobFile = false; - cleanupCommittedMobFile = true; // bulkload the ref file bulkloadRefFile(connection, table, bulkloadPathOfPartition, filePath.getName()); - cleanupCommittedMobFile = false; newFiles.add(new Path(mobFamilyDir, filePath.getName())); } @@ -702,9 +699,6 @@ public class PartitionedMobCompactor extends MobCompactor { deletePath(bulkloadPathOfPartition); } - if (cleanupCommittedMobFile) { - deletePath(new Path(mobFamilyDir, filePath.getName())); - } } } -- 2.17.2 (Apple Git-113)