Index: oak-security-spi/src/main/java/org/apache/jackrabbit/oak/spi/security/principal/GroupPrincipals.java IDEA additional info: Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP <+>UTF-8 =================================================================== --- oak-security-spi/src/main/java/org/apache/jackrabbit/oak/spi/security/principal/GroupPrincipals.java (revision 1855979) +++ oak-security-spi/src/main/java/org/apache/jackrabbit/oak/spi/security/principal/GroupPrincipals.java (date 1553245808000) @@ -58,6 +58,7 @@ * @param principal the principal whose membership is listed. * @return an enumeration of the group members. */ + @NotNull public static Enumeration members(@NotNull Principal principal) { if (principal instanceof Group) { return ((Group) principal).members(); @@ -84,7 +85,8 @@ return false; } - public static Set transform(Set groups) { + @NotNull + public static Set transform(@NotNull Set groups) { ImmutableSet.Builder g2 = ImmutableSet.builder(); for (Group g : groups) { g2.add(new GroupPrincipalWrapper(g)); @@ -92,7 +94,8 @@ return g2.build(); } - public static Enumeration transform(Enumeration members) { + @NotNull + public static Enumeration transform(@NotNull Enumeration members) { Iterator m2 = Iterators.transform(Iterators.forEnumeration(members), TRANSFORMER); return Iterators.asEnumeration(m2); }