Index: oak-security-spi/src/main/java/org/apache/jackrabbit/oak/spi/security/principal/GroupPrincipalWrapper.java IDEA additional info: Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP <+>UTF-8 =================================================================== --- oak-security-spi/src/main/java/org/apache/jackrabbit/oak/spi/security/principal/GroupPrincipalWrapper.java (revision 1855979) +++ oak-security-spi/src/main/java/org/apache/jackrabbit/oak/spi/security/principal/GroupPrincipalWrapper.java (date 1553245808000) @@ -33,11 +33,6 @@ this.group = group; } - @Override - public String getName() { - return group.getName(); - } - @Override public boolean isMember(Principal member) { return group.isMember(member); Index: oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/principal/GroupPrincipalWrapperTest.java IDEA additional info: Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP <+>UTF-8 =================================================================== --- oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/principal/GroupPrincipalWrapperTest.java (date 1553245977000) +++ oak-security-spi/src/test/java/org/apache/jackrabbit/oak/spi/security/principal/GroupPrincipalWrapperTest.java (date 1553245977000) @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.jackrabbit.oak.spi.security.principal; + +import org.junit.Before; +import org.junit.Test; + +import java.security.Principal; +import java.security.acl.Group; +import java.util.Collections; + +import static org.junit.Assert.assertEquals; +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.times; +import static org.mockito.Mockito.verify; +import static org.mockito.Mockito.when; + +public class GroupPrincipalWrapperTest { + + private Group g; + private GroupPrincipalWrapper wrapper; + + @Before + public void before() { + g = when(mock(Group.class).getName()).thenReturn("name").getMock(); + when(g.members()).thenReturn(Collections.emptyEnumeration()); + wrapper = new GroupPrincipalWrapper(g); + } + + @Test + public void testGetName() { + assertEquals("name", wrapper.getName()); + verify(g, times(1)).getName(); + } + + @Test + public void testIsMember() { + Principal p = mock(Principal.class); + wrapper.isMember(p); + verify(g, times(1)).isMember(p); + } + + @Test + public void testMembers() { + wrapper.members(); + verify(g, times(1)).members(); + } +} \ No newline at end of file