From 97322b7122e4bbbc737b184787cfce25126a4f0c Mon Sep 17 00:00:00 2001 From: Philippe Laflamme Date: Wed, 31 Oct 2018 14:50:52 -0400 Subject: [PATCH 1/2] Snapshot requests can be done concurrently and the master will simply run them sequentially. --- .../src/main/java/org/apache/hadoop/hbase/client/Admin.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java index 08b44c9301..27dca1a96a 100644 --- a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java +++ b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java @@ -1927,10 +1927,8 @@ public interface Admin extends Abortable, Closeable { IllegalArgumentException; /** - * Take a snapshot and wait for the server to complete that snapshot (blocking). Only a single - * snapshot should be taken at a time for an instance of HBase, or results may be undefined (you - * can tell multiple HBase clusters to snapshot at the same time, but only one at a time for a - * single cluster). Snapshots are considered unique based on the name of the snapshot. + * Take a snapshot and wait for the server to complete that snapshot (blocking). Snapshots + * are considered unique based on the name of the snapshot. * Attempts to take a snapshot with the same name (even a different type or with different * parameters) will fail with a {@link SnapshotCreationException} indicating the duplicate naming. * Snapshot names follow the same naming constraints as tables in HBase. See {@link -- 2.18.0 From 32a99d6c252e0e7e1104e901f209a1e14c13e743 Mon Sep 17 00:00:00 2001 From: Philippe Laflamme Date: Wed, 31 Oct 2018 20:25:12 -0400 Subject: [PATCH 2/2] Specify concurrency. --- .../src/main/java/org/apache/hadoop/hbase/client/Admin.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java index 27dca1a96a..dc797e95cf 100644 --- a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java +++ b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java @@ -1927,7 +1927,8 @@ public interface Admin extends Abortable, Closeable { IllegalArgumentException; /** - * Take a snapshot and wait for the server to complete that snapshot (blocking). Snapshots + * Take a snapshot and wait for the server to complete that snapshot (blocking). + * Snapshots are taken sequentially even when requested concurrently. Snapshots * are considered unique based on the name of the snapshot. * Attempts to take a snapshot with the same name (even a different type or with different * parameters) will fail with a {@link SnapshotCreationException} indicating the duplicate naming. -- 2.18.0