Index: dev-tools/scripts/smokeTestRelease.py IDEA additional info: Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP <+>UTF-8 =================================================================== --- dev-tools/scripts/smokeTestRelease.py (revision 8f498920bd4f2d0059031251409c812bab55404d) +++ dev-tools/scripts/smokeTestRelease.py (date 1536362205000) @@ -285,23 +285,22 @@ % (fullPath, luceneDistFilenames[jarFilename])) -def checkSigs(project, urlString, version, tmpDir, isSigned): +def checkSigs(project, urlString, version, tmpDir, isSigned, local_keys): print(' test basics...') ents = getDirEntries(urlString) artifact = None - keysURL = None changesURL = None mavenURL = None expectedSigs = [] if isSigned: expectedSigs.append('asc') expectedSigs.extend(['sha1', 'sha512']) - + artifacts = [] for text, subURL in ents: if text == 'KEYS': - keysURL = subURL + raise RuntimeError('%s: release dir should not contain a KEYS file - only toplevel /dist/lucene/KEYS is used' % project) elif text == 'maven/': mavenURL = subURL elif text.startswith('changes'): @@ -346,14 +345,16 @@ if expected != actual: raise RuntimeError('%s: wrong artifacts: expected %s but got %s' % (project, expected, actual)) - if keysURL is None: - raise RuntimeError('%s is missing KEYS' % project) - print(' get KEYS') - download('%s.KEYS' % project, keysURL, tmpDir) - - keysFile = '%s/%s.KEYS' % (tmpDir, project) - + if local_keys is not None: + print(" Using local KEYS file %s" % local_keys) + keysFile = local_keys + else: + keysFileURL = "https://archive.apache.org/dist/lucene/KEYS" + print(" Downloading online KEYS file %s" % keysFileURL) + download('KEYS' % keysFileURL, tmpDir) + keysFile = '%s/KEYS' % (tmpDir) + # Set up clean gpg world; import keys file: gpgHomeDir = '%s/%s.gpg' % (tmpDir, project) if os.path.exists(gpgHomeDir): @@ -1291,6 +1292,8 @@ help='Temporary directory to test inside, defaults to /tmp/smoke_lucene_$version_$revision') parser.add_argument('--not-signed', dest='is_signed', action='store_false', default=True, help='Indicates the release is not signed') + parser.add_argument('--local-keys', metavar='PATH', + help='Uses local KEYS file instead of fetching from https://archive.apache.org/dist/lucene/KEYS') parser.add_argument('--revision', help='GIT revision number that release was built with, defaults to that in URL') parser.add_argument('--version', metavar='X.Y.Z(-ALPHA|-BETA)?', @@ -1318,6 +1321,9 @@ c.revision = revision_match.group(1) print('Revision: %s' % c.revision) + if c.local_keys is not None and not os.path.exists(c.local_keys): + parser.error('Local KEYS file "%s" not found' % c.local_keys) + c.java = make_java_config(parser, c.test_java9) if c.tmp_dir: @@ -1462,9 +1468,9 @@ raise RuntimeError('smokeTestRelease.py for %s.X is incompatible with a %s release.' % (scriptVersion, c.version)) print('NOTE: output encoding is %s' % sys.stdout.encoding) - smokeTest(c.java, c.url, c.revision, c.version, c.tmp_dir, c.is_signed, ' '.join(c.test_args)) + smokeTest(c.java, c.url, c.revision, c.version, c.tmp_dir, c.is_signed, c.local_keys, ' '.join(c.test_args)) -def smokeTest(java, baseURL, gitRevision, version, tmpDir, isSigned, testArgs): +def smokeTest(java, baseURL, gitRevision, version, tmpDir, isSigned, local_keys, testArgs): startTime = datetime.datetime.now() @@ -1500,14 +1506,14 @@ print() print('Test Lucene...') - checkSigs('lucene', lucenePath, version, tmpDir, isSigned) + checkSigs('lucene', lucenePath, version, tmpDir, isSigned, local_keys) for artifact in ('lucene-%s.tgz' % version, 'lucene-%s.zip' % version): unpackAndVerify(java, 'lucene', tmpDir, artifact, gitRevision, version, testArgs, baseURL) unpackAndVerify(java, 'lucene', tmpDir, 'lucene-%s-src.tgz' % version, gitRevision, version, testArgs, baseURL) print() print('Test Solr...') - checkSigs('solr', solrPath, version, tmpDir, isSigned) + checkSigs('solr', solrPath, version, tmpDir, isSigned, local_keys) for artifact in ('solr-%s.tgz' % version, 'solr-%s.zip' % version): unpackAndVerify(java, 'solr', tmpDir, artifact, gitRevision, version, testArgs, baseURL) solrSrcUnpackPath = unpackAndVerify(java, 'solr', tmpDir, 'solr-%s-src.tgz' % version, Index: solr/build.xml IDEA additional info: Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP <+>UTF-8 =================================================================== --- solr/build.xml (revision 8f498920bd4f2d0059031251409c812bab55404d) +++ solr/build.xml (date 1536359870000) @@ -443,10 +443,6 @@ - - - - @@ -467,7 +463,7 @@ - + @@ -476,12 +472,6 @@ - - - - - UTF-8 =================================================================== --- lucene/common-build.xml (revision 8f498920bd4f2d0059031251409c812bab55404d) +++ lucene/common-build.xml (date 1536359870000) @@ -2380,32 +2380,6 @@ - - - - - - - - - - - Uploading artifacts to ${scp.user}@home.apache.org:${remote.staging.dir} - - - - - - - - - UTF-8 =================================================================== --- lucene/build.xml (revision 8f498920bd4f2d0059031251409c812bab55404d) +++ lucene/build.xml (date 1536359870000) @@ -387,7 +387,7 @@ - + @@ -396,19 +396,8 @@ - - - - - - - - - -