From 0ec2083fdd37f54294ffaae074406ecbc5b8c531 Mon Sep 17 00:00:00 2001 From: xcang Date: Thu, 6 Sep 2018 00:55:57 -0700 Subject: [PATCH] HBASE-15728 Fix findbugs regarding Inconsistent_Sync --- .../hadoop/hbase/regionserver/MetricsTableSourceImpl.java | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTableSourceImpl.java b/hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTableSourceImpl.java index 3da16b88bc..5e789d5062 100644 --- a/hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTableSourceImpl.java +++ b/hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsTableSourceImpl.java @@ -367,19 +367,19 @@ public class MetricsTableSourceImpl implements MetricsTableSource { } @Override - public void updateFlushMemstoreSize(long bytes) { + public synchronized void updateFlushMemstoreSize(long bytes) { flushMemstoreSizeHisto.add(bytes); flushedMemstoreBytes.incr(bytes); } @Override - public void updateFlushOutputSize(long bytes) { + public synchronized void updateFlushOutputSize(long bytes) { flushOutputSizeHisto.add(bytes); flushedOutputBytes.incr(bytes); } @Override - public void updateCompactionTime(boolean isMajor, long t) { + public synchronized void updateCompactionTime(boolean isMajor, long t) { compactionTimeHisto.add(t); if (isMajor) { majorCompactionTimeHisto.add(t); @@ -387,7 +387,7 @@ public class MetricsTableSourceImpl implements MetricsTableSource { } @Override - public void updateCompactionInputFileCount(boolean isMajor, long c) { + public synchronized void updateCompactionInputFileCount(boolean isMajor, long c) { compactionInputFileCountHisto.add(c); if (isMajor) { majorCompactionInputFileCountHisto.add(c); @@ -395,7 +395,7 @@ public class MetricsTableSourceImpl implements MetricsTableSource { } @Override - public void updateCompactionInputSize(boolean isMajor, long bytes) { + public synchronized void updateCompactionInputSize(boolean isMajor, long bytes) { compactionInputSizeHisto.add(bytes); compactedInputBytes.incr(bytes); if (isMajor) { @@ -405,7 +405,7 @@ public class MetricsTableSourceImpl implements MetricsTableSource { } @Override - public void updateCompactionOutputFileCount(boolean isMajor, long c) { + public synchronized void updateCompactionOutputFileCount(boolean isMajor, long c) { compactionOutputFileCountHisto.add(c); if (isMajor) { majorCompactionOutputFileCountHisto.add(c); @@ -413,7 +413,7 @@ public class MetricsTableSourceImpl implements MetricsTableSource { } @Override - public void updateCompactionOutputSize(boolean isMajor, long bytes) { + public synchronized void updateCompactionOutputSize(boolean isMajor, long bytes) { compactionOutputSizeHisto.add(bytes); compactedOutputBytes.incr(bytes); if (isMajor) { -- 2.15.1 (Apple Git-101)