From b55d2fcb7a66b120b7dcc7dca5072d4388b4423f Mon Sep 17 00:00:00 2001 From: Sean Busbey Date: Sun, 19 Aug 2018 22:29:46 -0500 Subject: [PATCH] HBASE-21074 JDK7 builds need to be done with TLSv1.2. --- dev-support/hbase-personality.sh | 3 +++ dev-support/hbase_nightly_source-artifact.sh | 3 ++- src/main/asciidoc/_chapters/developer.adoc | 4 ++++ 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/dev-support/hbase-personality.sh b/dev-support/hbase-personality.sh index 0b196908d5..1a7ec0b177 100755 --- a/dev-support/hbase-personality.sh +++ b/dev-support/hbase-personality.sh @@ -115,6 +115,9 @@ function personality_modules clear_personality_queue extra="-DHBasePatchProcess" + if [[ "${PATCH_BRANCH}" = branch-1* ]]; then + extra="${extra} -Dhttps.protocols=TLSv1.2" + fi if [[ -n "${HADOOP_PROFILE}" ]]; then extra="${extra} -Dhadoop.profile=${HADOOP_PROFILE}" diff --git a/dev-support/hbase_nightly_source-artifact.sh b/dev-support/hbase_nightly_source-artifact.sh index cde3b30a29..2e23994fdf 100755 --- a/dev-support/hbase_nightly_source-artifact.sh +++ b/dev-support/hbase_nightly_source-artifact.sh @@ -161,7 +161,8 @@ fi cd "${unpack_dir}" echo "Follow the ref guide section on making a RC: Step 8 Build the binary tarball." -if mvn -DskipTests -Prelease --batch-mode -Dmaven.repo.local="${m2_tarbuild}" clean install \ +# N.B. Older JDK7 requires the TLSv1.2 in order to talk to maven central +if mvn -Dhttps.protocols=TLSv1.2 -DskipTests -Prelease --batch-mode -Dmaven.repo.local="${m2_tarbuild}" clean install \ assembly:single >"${working_dir}/srctarball_install.log" 2>&1; then echo "Building a binary tarball from the source tarball succeeded." else diff --git a/src/main/asciidoc/_chapters/developer.adoc b/src/main/asciidoc/_chapters/developer.adoc index e41597cca2..35dc481092 100644 --- a/src/main/asciidoc/_chapters/developer.adoc +++ b/src/main/asciidoc/_chapters/developer.adoc @@ -472,7 +472,11 @@ mvn -DskipTests package assembly:single deploy [[build.gotchas]] ==== Build Gotchas +===== Failure to find dependencies with "protocol_version" error +Many maven repositories, most notably Maven Central, now require TLSv1.2 for HTTPS connections. On older JDK7 instances you may need to manually add +-Dhttps.protocols=TLSv1.2+ to your Maven command line invocation. + +===== Maven Site failure If you see `Unable to find resource 'VM_global_library.vm'`, ignore it. It's not an error. It is link:https://issues.apache.org/jira/browse/MSITE-286[officially ugly] though. -- 2.16.1