From 6fa0e22f46f37b2513e593a878262c53ec2d07a6 Mon Sep 17 00:00:00 2001 From: Sean Busbey Date: Wed, 15 Aug 2018 09:24:55 -0500 Subject: [PATCH] HBASE-21056 Findbugs false positive: BucketCache.persistToFile may fail to clean up java.io.OutputStream --- .../main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java index a862912f35..66ee0e405b 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java @@ -1081,6 +1081,8 @@ public class BucketCache implements BlockCache, HeapSize { /** * @see #retrieveFromFile(int[]) */ + @edu.umd.cs.findbugs.annotations.SuppressWarnings(value="OBL_UNSATISFIED_OBLIGATION", + justification = "false positive, try-with-resources ensures close is called.") private void persistToFile() throws IOException { assert !cacheEnabled; if (!ioEngine.isPersistent()) { -- 2.16.1