From 713c7d6d720c57e2d09ccadd537fbaa84b3f1dfc Mon Sep 17 00:00:00 2001 From: Nishant Date: Wed, 8 Aug 2018 17:22:08 +0530 Subject: [PATCH] [HIVE-20279] DruidQueryRecordReader return -1 to avoid checking for header and footer skip functionality review comment --- .../org/apache/hadoop/hive/druid/serde/DruidQueryRecordReader.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/druid-handler/src/java/org/apache/hadoop/hive/druid/serde/DruidQueryRecordReader.java b/druid-handler/src/java/org/apache/hadoop/hive/druid/serde/DruidQueryRecordReader.java index 215f4a2a03..78406bd506 100644 --- a/druid-handler/src/java/org/apache/hadoop/hive/druid/serde/DruidQueryRecordReader.java +++ b/druid-handler/src/java/org/apache/hadoop/hive/druid/serde/DruidQueryRecordReader.java @@ -142,7 +142,10 @@ public DruidWritable createValue() { @Override public long getPos() { - return 0; + // HiveContextAwareRecordReader uses this position to track the block position and check + // whether to skip header and footer. return -1 to since we need not skip any header and + // footer rows for druid. + return -1; } @Override -- 2.15.2 (Apple Git-101.1)