commit 596c79dbf76c110a0257eecccb862e8256eb89fe Author: Andrew Sherman Date: Mon Jul 23 17:19:47 2018 -0700 HIVE-20158: Do Not Print StackTraces to STDERR in Base64TextOutputFormat. Use java.nio.charset.StandardCharsets.UTF_8 to specify a Charset. diff --git contrib/src/java/org/apache/hadoop/hive/contrib/fileformat/base64/Base64TextInputFormat.java contrib/src/java/org/apache/hadoop/hive/contrib/fileformat/base64/Base64TextInputFormat.java index 4658469cfb2f22ab284fa311d043513de0d713c7..e809112db1eeca26575da1d12b7f0fea5dce2ab2 100644 --- contrib/src/java/org/apache/hadoop/hive/contrib/fileformat/base64/Base64TextInputFormat.java +++ contrib/src/java/org/apache/hadoop/hive/contrib/fileformat/base64/Base64TextInputFormat.java @@ -38,6 +38,7 @@ import org.apache.hadoop.mapred.RecordReader; import org.apache.hadoop.mapred.Reporter; import org.apache.hadoop.mapred.TextInputFormat; +import static java.nio.charset.StandardCharsets.UTF_8; /** * FileInputFormat for base64 encoded text files. @@ -131,15 +132,11 @@ public boolean next(LongWritable key, BytesWritable value) throws IOException { @Override public void configure(JobConf job) { - try { - String signatureString = job.get("base64.text.input.format.signature"); - if (signatureString != null) { - signature = signatureString.getBytes("UTF-8"); - } else { - signature = new byte[0]; - } - } catch (UnsupportedEncodingException e) { - e.printStackTrace(); + String signatureString = job.get("base64.text.input.format.signature"); + if (signatureString != null) { + signature = signatureString.getBytes(UTF_8); + } else { + signature = new byte[0]; } } diff --git contrib/src/java/org/apache/hadoop/hive/contrib/fileformat/base64/Base64TextOutputFormat.java contrib/src/java/org/apache/hadoop/hive/contrib/fileformat/base64/Base64TextOutputFormat.java index 20bbc46f3af395d7adf6856583b8048efb6c8c62..59c7025526d78a057bc84b09f6305d20fe40ac1e 100644 --- contrib/src/java/org/apache/hadoop/hive/contrib/fileformat/base64/Base64TextOutputFormat.java +++ contrib/src/java/org/apache/hadoop/hive/contrib/fileformat/base64/Base64TextOutputFormat.java @@ -33,6 +33,7 @@ import org.apache.hadoop.mapred.JobConf; import org.apache.hadoop.mapred.JobConfigurable; import org.apache.hadoop.util.Progressable; +import static java.nio.charset.StandardCharsets.UTF_8; /** * FileOutputFormat for base64 encoded text files. @@ -105,15 +106,11 @@ public void close(boolean abort) throws IOException { @Override public void configure(JobConf job) { - try { - String signatureString = job.get("base64.text.output.format.signature"); - if (signatureString != null) { - signature = signatureString.getBytes("UTF-8"); - } else { - signature = new byte[0]; - } - } catch (UnsupportedEncodingException e) { - e.printStackTrace(); + String signatureString = job.get("base64.text.output.format.signature"); + if (signatureString != null) { + signature = signatureString.getBytes(UTF_8); + } else { + signature = new byte[0]; } } }