From ce1eef5d745fa2ea791ec9c0edbe8b3b82531bb1 Mon Sep 17 00:00:00 2001 From: Josh Elser Date: Fri, 29 Jun 2018 15:19:59 -0400 Subject: [PATCH] HBASE-20826 Truncate really long RpcServer warnings unless TRACE is on --- .../src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java index 686d5785cc..ff5a128373 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java @@ -496,7 +496,12 @@ public abstract class RpcServer implements RpcServerInterface, responseInfo.put("class", server == null? "": server.getClass().getSimpleName()); responseInfo.put("method", methodName); responseInfo.put("call", call); - responseInfo.put("param", ProtobufUtil.getShortTextFormat(param)); + // The params could be really big, make sure they don't kill us at WARN + String stringifiedParam = ProtobufUtil.getShortTextFormat(param); + if (stringifiedParam.length() > 150 && !LOG.isTraceEnabled()) { + stringifiedParam = stringifiedParam.subSequence(0, 150) + " "; + } + responseInfo.put("param", stringifiedParam); if (param instanceof ClientProtos.ScanRequest && rsRpcServices != null) { ClientProtos.ScanRequest request = ((ClientProtos.ScanRequest) param); if (request.hasScannerId()) { -- 2.16.3