commit 231086cea90f7d749f57ddb11006788d6da7df49 Author: Bharath Krishna Date: Mon Jun 18 21:43:07 2018 -0700 HIVE-19942 : Hive Notification: All events for indexes should have table name. diff --git hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java index 8114d3598c43ee1f9cc0f54cb9b686e7e7e38a25..5fbba0ab54d36b4d0a903cbed7e65f0315585db3 100644 --- hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java +++ hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java @@ -411,6 +411,7 @@ public void onAddIndex(AddIndexEvent indexEvent) throws MetaException { new NotificationEvent(0, now(), EventType.CREATE_INDEX.toString(), msgFactory .buildCreateIndexMessage(index).toString()); event.setDbName(index.getDbName()); + event.setTableName(index.getOrigTableName()); process(event, indexEvent); } @@ -425,6 +426,7 @@ public void onDropIndex(DropIndexEvent indexEvent) throws MetaException { new NotificationEvent(0, now(), EventType.DROP_INDEX.toString(), msgFactory .buildDropIndexMessage(index).toString()); event.setDbName(index.getDbName()); + event.setTableName(index.getOrigTableName()); process(event, indexEvent); } @@ -440,6 +442,7 @@ public void onAlterIndex(AlterIndexEvent indexEvent) throws MetaException { new NotificationEvent(0, now(), EventType.ALTER_INDEX.toString(), msgFactory .buildAlterIndexMessage(before, after).toString()); event.setDbName(before.getDbName()); + event.setTableName(before.getOrigTableName()); process(event, indexEvent); } diff --git itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java index 269750984a03fca14d902cc503d89d8a77a094c2..93acf2b61b5d642e5d345feb32ed56c7b97ae134 100644 --- itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java +++ itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java @@ -1029,6 +1029,7 @@ public void createIndex() throws Exception { assertTrue(event.getEventTime() >= startTime); assertEquals(EventType.CREATE_INDEX.toString(), event.getEventType()); assertEquals(dbName, event.getDbName()); + assertEquals(tableName.toLowerCase(), event.getTableName().toLowerCase()); // Parse the message field CreateIndexMessage createIdxMessage = md.getCreateIndexMessage(event.getMessage()); @@ -1102,6 +1103,7 @@ public void dropIndex() throws Exception { assertTrue(event.getEventTime() >= startTime); assertEquals(EventType.DROP_INDEX.toString(), event.getEventType()); assertEquals(dbName, event.getDbName()); + assertEquals(tableName.toLowerCase(), event.getTableName().toLowerCase()); // Parse the message field DropIndexMessage dropIdxMsg = md.getDropIndexMessage(event.getMessage()); @@ -1180,6 +1182,7 @@ public void alterIndex() throws Exception { assertTrue(event.getEventTime() >= startTime); assertEquals(EventType.ALTER_INDEX.toString(), event.getEventType()); assertEquals(dbName, event.getDbName()); + assertEquals(tableName.toLowerCase(), event.getTableName().toLowerCase()); // Parse the message field AlterIndexMessage alterIdxMsg = md.getAlterIndexMessage(event.getMessage());