From e30decc60eef5f4dfaabb3a1d8a44b6d433cb921 Mon Sep 17 00:00:00 2001 From: Tai-Ying Lee Date: Mon, 30 Apr 2018 13:49:54 +0000 Subject: [PATCH] HBASE-20509 putting List in HashSet directly without using addAll function to improve performance --- .../apache/hadoop/hbase/favored/FavoredNodeAssignmentHelper.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/favored/FavoredNodeAssignmentHelper.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/favored/FavoredNodeAssignmentHelper.java index a1fde74..a754c6b 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/favored/FavoredNodeAssignmentHelper.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/favored/FavoredNodeAssignmentHelper.java @@ -395,8 +395,7 @@ public class FavoredNodeAssignmentHelper { rackSkipSet.add(primaryRack); String secondaryRack = getOneRandomRack(rackSkipSet); List serverList = getServersFromRack(secondaryRack); - Set serverSet = new HashSet<>(); - serverSet.addAll(serverList); + Set serverSet = new HashSet<>(serverList); ServerName[] favoredNodes; if (serverList.size() >= 2) { // Randomly pick up two servers from this secondary rack @@ -433,8 +432,7 @@ public class FavoredNodeAssignmentHelper { } secondaryRack = getOneRandomRack(rackSkipSet); serverList = getServersFromRack(secondaryRack); - serverSet = new HashSet<>(); - serverSet.addAll(serverList); + serverSet = new HashSet<>(serverList); } // Place the secondary RS -- 2.7.4