From 4414bbefda5c24f7d15ac5c59887e20ed42ac570 Mon Sep 17 00:00:00 2001 From: Sakthi Date: Wed, 25 Apr 2018 21:00:23 -0700 Subject: [PATCH] HBASE-20482 Printed a link to the ref guide chapter for the shell during startup --- hbase-shell/src/main/ruby/shell.rb | 1 + hbase-shell/src/test/ruby/shell/shell_test.rb | 14 +++++++++++++- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/hbase-shell/src/main/ruby/shell.rb b/hbase-shell/src/main/ruby/shell.rb index dcbe6e62d38daf67a832f459c58d8be9fba12dcd..7b4dbc9d310a745d7f6dd5fdff9e235c9825682e 100644 --- a/hbase-shell/src/main/ruby/shell.rb +++ b/hbase-shell/src/main/ruby/shell.rb @@ -143,6 +143,7 @@ module Shell def print_banner puts "HBase Shell; enter 'help' for list of supported commands." puts 'Type "exit" to leave the HBase Shell' + puts 'For Reference, please visit: http://hbase.apache.org/1.2/book.html#shell' print 'Version ' command('version') puts diff --git a/hbase-shell/src/test/ruby/shell/shell_test.rb b/hbase-shell/src/test/ruby/shell/shell_test.rb index 56b7dc81286fe4c45e1b0a21c0366c566d3fafa0..e063bcf6d9889cfbeebc065618b634724800c475 100644 --- a/hbase-shell/src/test/ruby/shell/shell_test.rb +++ b/hbase-shell/src/test/ruby/shell/shell_test.rb @@ -22,6 +22,8 @@ require 'shell' require 'shell/formatter' class ShellTest < Test::Unit::TestCase + include Hbase::TestHelpers + def setup @formatter = ::Shell::Formatter::Console.new() @hbase = ::Hbase::Hbase.new($TEST_CLUSTER.getConfiguration) @@ -67,7 +69,17 @@ class ShellTest < Test::Unit::TestCase @shell.command('version') end - #------------------------------------------------------------------------------- + #----------------------------------------------------------------------------- + + define_test 'Shell::Shell#print_banner should display Reference Guide link' do + @shell.interactive = true + output = capture_stdout { @shell.print_banner } + @shell.interactive = false + link_regex = %r{For Reference, please visit: http://hbase.apache.org/1.2/book.html#shell} + assert_match(link_regex, output) + end + + #----------------------------------------------------------------------------- define_test "Shell::Shell interactive mode should not throw" do # incorrect number of arguments -- 2.15.1 (Apple Git-101)