From 29b87672cba7f92f9c8ee4692b81144916af92c3 Mon Sep 17 00:00:00 2001 From: Sakthi Date: Wed, 25 Apr 2018 21:00:23 -0700 Subject: [PATCH] HBASE-20482 Printed a link to the ref guide chapter for the shell during startup --- hbase-shell/src/main/ruby/shell.rb | 1 + hbase-shell/src/test/ruby/shell/shell_test.rb | 14 +++++++++++++- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/hbase-shell/src/main/ruby/shell.rb b/hbase-shell/src/main/ruby/shell.rb index ab07a79b985d9a724db607dbcd7fd24ce2c2e536..1d0f8443f587a8cc3320bb1312a1c7d9b3fa3155 100644 --- a/hbase-shell/src/main/ruby/shell.rb +++ b/hbase-shell/src/main/ruby/shell.rb @@ -152,6 +152,7 @@ module Shell puts 'HBase Shell' puts 'Use "help" to get list of supported commands.' puts 'Use "exit" to quit this interactive shell.' + puts 'For Reference, please visit: http://hbase.apache.org/book.html#shell' print 'Version ' command('version') puts diff --git a/hbase-shell/src/test/ruby/shell/shell_test.rb b/hbase-shell/src/test/ruby/shell/shell_test.rb index ab150a5478ff8973c4a171e92685e7a120e63153..593e5019a73f24ad72033fc6729d58876d247b15 100644 --- a/hbase-shell/src/test/ruby/shell/shell_test.rb +++ b/hbase-shell/src/test/ruby/shell/shell_test.rb @@ -21,6 +21,8 @@ require 'hbase_constants' require 'shell' class ShellTest < Test::Unit::TestCase + include Hbase::TestHelpers + def setup @hbase = ::Hbase::Hbase.new($TEST_CLUSTER.getConfiguration) @shell = Shell::Shell.new(@hbase) @@ -69,7 +71,17 @@ class ShellTest < Test::Unit::TestCase @shell.command('version') end - #------------------------------------------------------------------------------- + #----------------------------------------------------------------------------- + + define_test 'Shell::Shell#print_banner should display Reference Guide link' do + @shell.interactive = true + output = capture_stdout { @shell.print_banner } + @shell.interactive = false + link_regex = %r{For Reference, please visit: http://hbase.apache.org/book.html#shell} + assert_match(link_regex, output) + end + + #----------------------------------------------------------------------------- define_test "Shell::Shell interactive mode should not throw" do # incorrect number of arguments -- 2.15.1 (Apple Git-101)