From c1d47c3c57d30b9acacc328a9fcf23f0cf41556b Mon Sep 17 00:00:00 2001 From: Mike Drob Date: Thu, 8 Mar 2018 21:55:25 -0600 Subject: [PATCH 1/2] HBASE-20164 add hadoopcheck link to table footer Signed-off-by: Sean Busbey --- dev-support/hbase-personality.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dev-support/hbase-personality.sh b/dev-support/hbase-personality.sh index 9064f0b62a..b2fc76eb54 100755 --- a/dev-support/hbase-personality.sh +++ b/dev-support/hbase-personality.sh @@ -370,6 +370,7 @@ function hadoopcheck_rebuild count=$(${GREP} -c '\[ERROR\]' "${logfile}") if [[ ${count} -gt 0 ]]; then add_vote_table -1 hadoopcheck "${BUILDMODEMSG} causes ${count} errors with Hadoop v${hadoopver}." + add_footer_table hadoopcheck "@@BASE@@/patch-javac-${hadoopver}.txt" ((result=result+1)) fi done @@ -384,6 +385,7 @@ function hadoopcheck_rebuild count=$(${GREP} -c '\[ERROR\]' "${logfile}") if [[ ${count} -gt 0 ]]; then add_vote_table -1 hadoopcheck "${BUILDMODEMSG} causes ${count} errors with Hadoop v${hadoopver}." + add_footer_table hadoopcheck "@@BASE@@/patch-javac-${hadoopver}.txt" ((result=result+1)) fi done -- 2.16.1 From f1d29ca5971e8659751b8a47609c8cd53b6626dc Mon Sep 17 00:00:00 2001 From: Sean Busbey Date: Fri, 9 Mar 2018 10:38:36 -0600 Subject: [PATCH 2/2] WIP touching a java file so hadoopcheck will fire in precommit. --- .../main/java/org/apache/hadoop/hbase/CompatibilityFactory.java | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/CompatibilityFactory.java b/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/CompatibilityFactory.java index 5c1f1035f5..9821301435 100644 --- a/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/CompatibilityFactory.java +++ b/hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/CompatibilityFactory.java @@ -16,10 +16,13 @@ * limitations under the License. */ +// please don't commit me! + package org.apache.hadoop.hbase; import java.util.Iterator; import java.util.ServiceLoader; +import org.apache.hadoop.fs.FSInputStream; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -33,6 +36,10 @@ public class CompatibilityFactory { public static final String EXCEPTION_START = "Could not create "; public static final String EXCEPTION_END = " Is the hadoop compatibility jar on the classpath?"; + { + FSInputStream dummy = new FSInputStream(); + } + /** * This is a static only class don't let any instance be created. */ -- 2.16.1