Index: oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/permission/MountPermissionProvider.java IDEA additional info: Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP <+>UTF-8 =================================================================== --- oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/permission/MountPermissionProvider.java (revision 1822875) +++ oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/permission/MountPermissionProvider.java (revision ) @@ -23,7 +23,9 @@ import java.util.List; import java.util.Set; +import javax.annotation.CheckForNull; import javax.annotation.Nonnull; +import javax.annotation.Nullable; import org.apache.jackrabbit.oak.api.Root; import org.apache.jackrabbit.oak.commons.LongUtils; @@ -34,8 +36,6 @@ import org.apache.jackrabbit.oak.spi.security.Context; import org.apache.jackrabbit.oak.spi.security.authorization.restriction.RestrictionProvider; -import com.google.common.collect.ImmutableSet; - public class MountPermissionProvider extends PermissionProviderImpl { @Nonnull @@ -79,20 +79,22 @@ this.stores = stores; } + @CheckForNull @Override - public Collection load(Collection entries, String principalName, - String path) { + public Collection load(@Nullable Collection entries, @Nonnull String principalName, + @Nonnull String path) { for (PermissionStoreImpl store : stores) { Collection col = store.load(null, principalName, path); if (col != null && !col.isEmpty()) { return col; } } - return ImmutableSet.of(); + return null; } + @Nonnull @Override - public PrincipalPermissionEntries load(String principalName) { + public PrincipalPermissionEntries load(@Nonnull String principalName) { PrincipalPermissionEntries ppe = new PrincipalPermissionEntries(); for (PermissionStoreImpl store : stores) { ppe.getEntries().putAll(store.load(principalName).getEntries()); @@ -102,7 +104,7 @@ } @Override - public long getNumEntries(String principalName, long max) { + public long getNumEntries(@Nonnull String principalName, long max) { long num = 0; for (PermissionStoreImpl store : stores) { num = LongUtils.safeAdd(num, store.getNumEntries(principalName, max)); @@ -114,7 +116,7 @@ } @Override - public void flush(Root root) { + public void flush(@Nonnull Root root) { for (PermissionStoreImpl store : stores) { store.flush(root); }