From 746ccfa46624a6a49f72ce6383367104ecb5058a Mon Sep 17 00:00:00 2001 From: Apekshit Sharma Date: Thu, 18 Jan 2018 11:34:21 -0800 Subject: [PATCH] HBASE-19823 Make RawCellBuilderFactory LimitedPrivate.UNITTEST --- .../main/java/org/apache/hadoop/hbase/HBaseInterfaceAudience.java | 1 + .../src/main/java/org/apache/hadoop/hbase/RawCellBuilder.java | 3 ++- .../src/main/java/org/apache/hadoop/hbase/RawCellBuilderFactory.java | 5 +++-- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/hbase-common/src/main/java/org/apache/hadoop/hbase/HBaseInterfaceAudience.java b/hbase-common/src/main/java/org/apache/hadoop/hbase/HBaseInterfaceAudience.java index 3a51bd5bba..4e034577b7 100644 --- a/hbase-common/src/main/java/org/apache/hadoop/hbase/HBaseInterfaceAudience.java +++ b/hbase-common/src/main/java/org/apache/hadoop/hbase/HBaseInterfaceAudience.java @@ -36,6 +36,7 @@ public final class HBaseInterfaceAudience { public static final String REPLICATION = "Replication"; public static final String PHOENIX = "Phoenix"; public static final String SPARK = "Spark"; + public static final String UNITTEST = "Unittest"; /** * Denotes class names that appear in user facing configuration files. diff --git a/hbase-common/src/main/java/org/apache/hadoop/hbase/RawCellBuilder.java b/hbase-common/src/main/java/org/apache/hadoop/hbase/RawCellBuilder.java index 9e89307ba1..f7797293e0 100644 --- a/hbase-common/src/main/java/org/apache/hadoop/hbase/RawCellBuilder.java +++ b/hbase-common/src/main/java/org/apache/hadoop/hbase/RawCellBuilder.java @@ -23,7 +23,8 @@ import org.apache.yetus.audience.InterfaceAudience; /** * Allows creating a cell with {@link Tag} - * An instance of this type can be acquired using RegionCoprocessorEnvironment#getCellBuilder. + * An instance of this type can be acquired by using RegionCoprocessorEnvironment#getCellBuilder + * (for prod code) and {@link RawCellBuilderFactory} (for unit tests). */ @InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.COPROC) public interface RawCellBuilder extends CellBuilder { diff --git a/hbase-common/src/main/java/org/apache/hadoop/hbase/RawCellBuilderFactory.java b/hbase-common/src/main/java/org/apache/hadoop/hbase/RawCellBuilderFactory.java index 0f61ee85a9..f7ff952756 100644 --- a/hbase-common/src/main/java/org/apache/hadoop/hbase/RawCellBuilderFactory.java +++ b/hbase-common/src/main/java/org/apache/hadoop/hbase/RawCellBuilderFactory.java @@ -23,10 +23,11 @@ import org.apache.yetus.audience.InterfaceAudience; /** * Factory for creating cells for CPs. It does deep_copy {@link CellBuilderType#DEEP_COPY} while * creating cells. - * This is private because coprocessors should get an instance of type {@link RawCellBuilder} + * This class is limited private only for use in unit-tests. + * For non-test uses in coprocessors, get an instance of type {@link RawCellBuilder} * using RegionCoprocessorEnvironment#getCellBuilder. */ -@InterfaceAudience.Private +@InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.UNITTEST) public final class RawCellBuilderFactory { /** -- 2.14.1